Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontpage-cleanup #1353

Merged
merged 9 commits into from
Jun 28, 2024
Merged

frontpage-cleanup #1353

merged 9 commits into from
Jun 28, 2024

Conversation

adriansergheev
Copy link
Collaborator

@adriansergheev adriansergheev commented Jun 19, 2024 •
edited
Loading

Why?

  • we're deprecating FinniversKit in favour of Warp. Besides that, significant portions of the front page are being transitioned to SwiftUI. For example the MarketGrid is re-designed and re-written in SwiftUI.

What?

  • remove MarketGrid, CompactMarketGrid and FrontPageView from FinniversKit and move them to the internal repo.

Version Change

  • breaking!

@adriansergheev adriansergheev marked this pull request as ready for review June 24, 2024 15:18
@adriansergheev adriansergheev merged commit 5ed6a38 into master Jun 28, 2024
1 check passed
@adriansergheev adriansergheev deleted the frontpage-cleanup branch June 28, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinsalehjan robinsalehjan robinsalehjan approved these changes

@bstien bstien Awaiting requested review from bstien

@ninarg ninarg Awaiting requested review from ninarg

@osanoj osanoj Awaiting requested review from osanoj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriansergheev @robinsalehjan