Braze Content card with top aligned image #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teddyfahi
requested review from
a team,
ninarg and
sakhnenkoff
and removed request for
a team
ninarg
approved these changes
Jun 24, 2024
FinniversKit/Sources/Components/BrazePromotionView/BrazePromotionView.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Similar to our default content card with a right aligned image, just add a different option to cardStyle to add a capability of having the image above the content.
Note: there is an ongoing discussion regarding this potentially huge image/impact on the front page. Pr might change depending on the outcome of that discussion: https://github.schibsted.io/finn/android_finn_app/pull/7914#issuecomment-1587168
What?
.top is added to the image position enum that decides how the card style is layed out. The .topAlignedGraphic value is added to the cardStyle braze key.
Version Change
Minor change.
UI Changes
If the change concerns UI, a transition or an animation, providing an image, a gif, or a video is encouraged to help us reviewing your PR.