recommendations-iPad-fix #1369
Merged
recommendations-iPad-fix #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 13, 2024 10:38
adriansergheev
commented
Aug 13, 2024
| @@ -51,15 +47,14 @@ public class AdRecommendationsGridView: UIView { | |||
|
|
|||
| private let imageCache = ImageMemoryCache() | |||
|
|
|||
| private lazy var collectionViewLayout: AdRecommendationsGridViewLayout = { | |||
There was a problem hiding this comment.
since collectionView is a mutable var, it's best to re-create the layout
| return itemAttributes[indexPath.row] | ||
| guard itemAttributes.indices.contains(indexPath.row) | ||
| else { return nil } | ||
| if itemAttributes[indexPath.row].representedElementCategory == .cell { |
There was a problem hiding this comment.
fix:
the method layoutAttributesForItem retrieves layout info at the indexPath and it works for cells only
we have above a UICollectionViewLayoutAttributes for the header which is stored in the same array
for some reason, on iPads when launching the app from background this method is called with indexPath.row == 0 which would cause a crash, since at index 0 in the array we have a layout attribute for a header and not for a cell
on iPhones, the call is missing 🤷♂️
osanoj
reviewed
Aug 13, 2024
Comment on lines
+121
to
+127
| guard itemAttributes.indices.contains(indexPath.row) | ||
| else { return nil } | ||
| if itemAttributes[indexPath.row].representedElementCategory == .cell { | ||
| return itemAttributes[indexPath.row] | ||
| } else { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Suggested change
| guard itemAttributes.indices.contains(indexPath.row) | |
| else { return nil } | |
| if itemAttributes[indexPath.row].representedElementCategory == .cell { | |
| return itemAttributes[indexPath.row] | |
| } else { | |
| return nil | |
| } | |
| if let itemAttribute = itemAttributes[safe: indexPath.row], itemAttribute.representedElementCategory == .cell { | |
| return itemAttribute | |
| } else { | |
| return nil | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
What?
AdRecommendationsGridViewLayoutVersion Change
patch
UI Changes