frontpage-recommendations-externalAd-layout #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 15, 2024 10:54
adriansergheev
force-pushed
the
frontpage-recommendations-layout
branch
from
7b87ec9
to
7f470b1
Compare
adriansergheev
commented
Aug 15, 2024
| @@ -176,6 +183,7 @@ public class ExternalAdRecommendationCell: UICollectionViewCell, AdRecommendatio | |||
| titleLabel.topAnchor.constraint(equalTo: subtitleLabel.bottomAnchor, constant: ExternalAdRecommendationCell.titleTopMargin), | |||
| titleLabel.leadingAnchor.constraint(equalTo: contentView.leadingAnchor), | |||
| titleLabel.trailingAnchor.constraint(equalTo: contentView.trailingAnchor), | |||
| titleLabel.bottomAnchor.constraint(equalTo: contentView.bottomAnchor), | |||
ninarg
approved these changes
Aug 15, 2024
| let imageHeightMinimumConstraint = imageContentView.heightAnchor.constraint(equalTo: imageContentView.widthAnchor, multiplier: ExternalAdRecommendationCell.minImageAspectRatio) | ||
| let imageHeightMaximumConstraint = imageContentView.heightAnchor.constraint(lessThanOrEqualTo: imageContentView.widthAnchor, multiplier: ExternalAdRecommendationCell.maxImageAspectRatio) | ||
|
|
||
| imageHeightMinimumConstraint.priority = .defaultHigh |
There was a problem hiding this comment.
I wonder why we set these min and max height constraints, instead of setting the actual height based on image size when configuring the cell with the model 🤔 But I see we do the same in StandardAdRecommendationCell, so if it works there it should work here as well 👍
There was a problem hiding this comment.
when we got a new report, i decided to revert my previous changes from here and attempt to fix it from scratch
then i noticed that the label had a constraint missing! added it and it seemed to make auto layout happy!
now i wonder why i did not see it last time...
There was a problem hiding this comment.
awesome 👍 haha not easy to see this stuff 👁️
| @@ -176,6 +183,7 @@ public class ExternalAdRecommendationCell: UICollectionViewCell, AdRecommendatio | |||
| titleLabel.topAnchor.constraint(equalTo: subtitleLabel.bottomAnchor, constant: ExternalAdRecommendationCell.titleTopMargin), | |||
| titleLabel.leadingAnchor.constraint(equalTo: contentView.leadingAnchor), | |||
| titleLabel.trailingAnchor.constraint(equalTo: contentView.trailingAnchor), | |||
| titleLabel.bottomAnchor.constraint(equalTo: contentView.bottomAnchor), | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
the previous fix worked only for FinniversKit
In the actual app we still had issues from time to time due to a missing constraint
What?
reverts #1324 and fixes the actual issue
Version Change
UI Changes