Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for pydantic v2 and fixed build issues, building packages with yaml files. #86

Merged

Conversation

varunmittal91
Copy link
Collaborator

This pull request resolves compatibility issues with focus-converter.

Also the python package built did not include yaml due to them being soft-links. This changes soft-linked files to hard links.

Signed-off-by: Varun Mittal <varunmittal91@gmail.com>
@mike-finopsorg
Copy link
Contributor

@varunmittal91 can you check the unittests on this one. I see an error
FAILED tests/config_objects/test_check_type_friendly_name.py::TestCheckTypeFriendlyName::test_generate_name_for_check_types - polyfactory.exceptions.ConfigurationException: Model type Rule is not supported. To support it, register an appropriate base factory and subclass it for your factory.

Signed-off-by: Varun Mittal <varunmittal91@gmail.com>
@varunmittal91 varunmittal91 force-pushed the add-support-for-v2-pydantic branch from 7cc9c17 to 887a134 Compare October 19, 2023 20:29
Signed-off-by: Varun Mittal <varunmittal91@gmail.com>
@varunmittal91
Copy link
Collaborator Author

@varunmittal91 can you check the unittests on this one. I see an error FAILED tests/config_objects/test_check_type_friendly_name.py::TestCheckTypeFriendlyName::test_generate_name_for_check_types - polyfactory.exceptions.ConfigurationException: Model type Rule is not supported. To support it, register an appropriate base factory and subclass it for your factory.

All done, also removed pkg_resource warning by moving to importlib. Python 3.8 will still need to use the old api.

Signed-off-by: Varun Mittal <varunmittal91@gmail.com>
Signed-off-by: Varun Mittal <varunmittal91@gmail.com>
Signed-off-by: Varun Mittal <varunmittal91@gmail.com>
@varunmittal91 varunmittal91 force-pushed the add-support-for-v2-pydantic branch from b6b72fd to bc21602 Compare October 19, 2023 21:24
@varunmittal91 varunmittal91 changed the base branch from main to dev October 20, 2023 04:40
Signed-off-by: Varun Mittal <varunmittal91@gmail.com>
…dev.

Signed-off-by: Varun Mittal <varunmittal91@gmail.com>
@varunmittal91 varunmittal91 force-pushed the add-support-for-v2-pydantic branch from 01f417b to 00d6990 Compare October 20, 2023 04:45
@varunmittal91 varunmittal91 merged commit f183816 into finopsfoundation:dev Oct 20, 2023
varunmittal91 added a commit that referenced this pull request Oct 20, 2023
…es with yaml files. (#86)

Signed-off-by: Varun Mittal <varunmittal91@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants