Review comments

- remove FDS_ID from contact - make holding mandatory on position
finos · Feb 13, 2020 · 17cec02 · 17cec02
1 parent 6006d0c
commit 17cec02
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/src/context/schemas/contact.schema.json b/src/context/schemas/contact.schema.json
@@ -8,8 +8,7 @@
     "id": {
       "type": "object",
       "properties": {
-        "email": { "type": "string" },
-        "FDS_ID": { "type": "string" }
+        "email": { "type": "string" }
       }
     }
   },

diff --git a/src/context/schemas/position.schema.json b/src/context/schemas/position.schema.json
@@ -8,5 +8,5 @@
     "instrument": { "$ref": "instrument.schema#/" },
     "holding": { "type": "number", "minimum": 0 }
   },
-  "required": ["instrument"]
+  "required": ["instrument","holding"]
 }
diff --git a/website/static/schemas/next/contact.schema.json b/website/static/schemas/next/contact.schema.json
@@ -8,8 +8,7 @@
     "id": {
       "type": "object",
       "properties": {
-        "email": { "type": "string" },
-        "FDS_ID": { "type": "string" }
+        "email": { "type": "string" }
       }
     }
   },

diff --git a/website/static/schemas/next/position.schema.json b/website/static/schemas/next/position.schema.json
@@ -8,5 +8,5 @@
     "instrument": { "$ref": "instrument.schema#/" },
     "holding": { "type": "number", "minimum": 0 }
   },
-  "required": ["instrument"]
+  "required": ["instrument","holding"]
 }