review: make intent type free, rename intent+context to action

finos · Aug 5, 2022 · 75141ff · 75141ff
1 parent 56479cc
commit 75141ff
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 43 deletions.
diff --git a/src/context/schemas.json b/src/context/schemas.json
@@ -1,4 +1,5 @@
 {
+  "Action": ["https://fdc3.finos.org/schemas/next/action.schema.json"],
   "Context": ["https://fdc3.finos.org/schemas/next/context.schema.json"],
   "Chart": ["https://fdc3.finos.org/schemas/next/chart.schema.json"],
   "ChatInitSettings": ["https://fdc3.finos.org/schemas/next/chatInitSettings.schema.json"],
@@ -9,7 +10,6 @@
   "Email": ["https://fdc3.finos.org/schemas/next/email.schema.json"],
   "Instrument": ["https://fdc3.finos.org/schemas/next/instrument.schema.json"],
   "InstrumentList": ["https://fdc3.finos.org/schemas/next/instrumentList.schema.json"],
-  "Intent": ["https://fdc3.finos.org/schemas/next/intent.schema.json"],
   "Message": ["https://fdc3.finos.org/schemas/next/message.schema.json"],
   "Nothing": ["https://fdc3.finos.org/schemas/next/nothing.schema.json"],
   "Organization": ["https://fdc3.finos.org/schemas/next/organization.schema.json"],

diff --git a/src/context/schemas/action.schema.json b/src/context/schemas/action.schema.json
@@ -0,0 +1,25 @@
+{
+  "$schema": "http://json-schema.org/draft-07/schema#",
+  "$id": "https://fdc3.finos.org/schemas/next/action.schema.json",
+  "type": "object",
+  "title": "Action",
+  "properties": {
+    "title": {
+      "type": "string"
+    },
+    "intent": {
+      "type": "string",
+      "$comment": "Should reference one of the intent types listed in 'standard intents'"
+    },
+    "context": {
+      "type": "object",
+      "$ref": "context.schema.json#"
+    },
+    "customConfig": {
+      "type": "object"
+    }
+  },
+  "required": [
+    "title", "context"
+  ]
+}
diff --git a/src/context/schemas/intent.schema.json b/src/context/schemas/intent.schema.json
diff --git a/src/context/schemas/message.schema.json b/src/context/schemas/message.schema.json
@@ -23,12 +23,12 @@
             "type": "object",
             "allOf": [
               {
-                "$ref": "intent.schema.json#"
+                "$ref": "action.schema.json#"
               }
             ],
             "properties": {
               "type": {
-                "const": "fdc3.entity.intent"
+                "const": "fdc3.entity.action"
               }
             },
             "required": ["type"]