Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Hugh Troeger <htroeger@factset.com>
  • Loading branch information
kriswest and hughtroeger authored May 26, 2022
1 parent 4f5898d commit e5ba993
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
* `IntentResolution` now requires the name of the intent raised to included, allowing it to be used to determine the intent raised via `fdc3.raiseIntentForContext()`. ([#507](https://github.com/finos/FDC3/pull/507))
* A Trademarks page was added to acknowledge trademarks used within the Standard not owned by FINOS or the Linux Foundation ([#534](https://github.com/finos/FDC3/pull/534))
* Added details of FDC3's existing versioning and deprecation policies to the FDC3 compliance page ([#539](https://github.com/finos/FDC3/pull/539))
* Added `IntentDeliveryFailed` to the `ResolveError` enumeration to be used when delivery of an intent and context to a targetted app or instance fails. ([#601](https://github.com/finos/FDC3/pull/601))
* Added `IntentDeliveryFailed` to the `ResolveError` enumeration to be used when delivery of an intent and context to a targeted app or instance fails. ([#601](https://github.com/finos/FDC3/pull/601))
* Added a new experimental features policy, which exempts features designated as experimental from the versioning and deprecation policies, to the FDC3 compliance page ([#549](https://github.com/finos/FDC3/pull/549))
* Add `IntentDeliveryFailed` to the `ResolveError` enumeration to be used when delivery of an intent and context to a targetted app or instance fails. ([#601](https://github.com/finos/FDC3/pull/601))
* Added a context type representing a range of time (`fdc3.timerange`). ([#706](https://github.com/finos/FDC3/pull/706))
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ The next section contains more information on the workflow followed for Pull Req

- All PRs will be reviewed by at least one of the FDC3 Maintainers and any appointed Editors. PRs are also open to review by FDC3 Participants.

- The FDC3 Maintainers are responsible for ensuring that the the Standard Working Group has been consulted on either an issue (that provides a high-level of detail on the proposed changes) or on the PR itself, a decision has been reached that the change should be made and that that decision has been documented.
- The FDC3 Maintainers are responsible for ensuring that the Standard Working Group has been consulted on either an issue (that provides a high-level of detail on the proposed changes) or on the PR itself, a decision has been reached that the change should be made and that that decision has been documented.

- All reviews will be completed using the Github review tool.

Expand Down
2 changes: 1 addition & 1 deletion docs/context/ref/ChatInitSettings.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ https://fdc3.finos.org/schemas/next/chatInitSettings.schema.json
| Property | Type | Required | Example Value |
| ------------------------------ | ----------- | -------- | -------------------------------------------------------------------- |
| `type` | string | Yes | `'fdc3.chat.initSettings'` |
| `chatName` | string | No | `'Instrumet XYZ'` |
| `chatName` | string | No | `'Instrument XYZ'` |
| `members` | ContactList | No | ContactList - cf. below |
| `initMessage` | string | No | `'Hello!'` |
| `options.groupRecipients` | boolean | No | `true`: if false a separate chat will be created for each member |
Expand Down
4 changes: 2 additions & 2 deletions docs/context/spec.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ Times MAY be expressed with millisecond precision, e.g.:
* `"2022-03-30T11:44:44.123-04:00"`
* `"2022-03-30T11:44:44.123Z"`

Parsing in Javascript:
Parsing in JavaScript:

```javascript
let aDate = new Date("2022-03-30T11:44:44.123-04:00")
Expand All @@ -115,7 +115,7 @@ Fields representing a point in time SHOULD be string encoded using the `YYYY-MM-

E.g. `"2022-03-30"`

Parsing in Javascript:
Parsing in JavaScript:

```javascript
let aDate = new Date("2022-03-30")
Expand Down
2 changes: 1 addition & 1 deletion docs/intents/ref/StartChat.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const initSettings = {
public: false, // private chat room
allowHistoryBrowsing: true,
allowMessageCopy: true,
allowAddUser: false, // John won't be auhtorized to add other users to the chat
allowAddUser: false, // John won't be authorized to add other users to the chat
}
initMessage: 'Hello John!'
}
Expand Down

0 comments on commit e5ba993

Please sign in to comment.