Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Directory schema contains errors #1033

Closed
kriswest opened this issue Jul 24, 2023 · 0 comments · Fixed by #1034 or #1035
Closed

App Directory schema contains errors #1033

kriswest opened this issue Jul 24, 2023 · 0 comments · Fixed by #1034 or #1035
Labels
app-directory bug Something isn't working
Milestone

Comments

@kriswest
Copy link
Contributor

kriswest commented Jul 24, 2023

Area of Issue

[x] App Directory

Issue Description:

The app directory schema is currently failing its test. The example schema at https://github.com/InteropIO/FDC3/blob/544-Desktop-Agent_bridging-Proposal-mk2/src/app-directory/specification/examples/application/fdc3-workbench.json contains error (type should be "web" rather than "browser". However, once corrected the test still won't pass as the details element can't be validated (due to the use of oneOf, where the subschemas overap - this should be anyOf), amongst other errors.

Errors are only returned one at a time due to the encoding in YAML, switching to JSON schema would allow all errors to output at once.

Correct the errors in the App Directory schema and consider switching the encoding to JSON Schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-directory bug Something isn't working
Projects
None yet
1 participant