1033 convert appd schema to json #1035
Conversation
…prove test - the details field of the appD schema is using `oneOf` to combine subschemas, however, this requires them to be distinct and non-verlapping. This should be `anyOf` instead as this prevents validation errors when the element conforms to multiple subschemas. - commas were removed from email fields in the fdc3-workbench example as these fail validation - The test was improved by adding multiple examples and providing better output from it.
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Works for me 👍 |
There was a problem hiding this comment.
Comments are about double spaces. Was a little unsure about all the newlines in the description fields. Some clearly delineate mini paragraphs, but some occur mid sentence and some have trailing newlines while others do not. Anyway all whitespace issues, content looks good.
Co-authored-by: Hugh Troeger <troeger.hugh@gmail.com>
Co-authored-by: Hugh Troeger <troeger.hugh@gmail.com>
…/InteropIO/FDC3 into 1033-convert-appd-schema-to-json
I suspect all of these were existing in the YAML file, which is an awkward format unless you're really used to it. A good reason to convert to JSON Schema! Edit: checked and yes double spacing and line breaks were in YAML. Interestingly none were rendered. This is because all the copy is encoded in markdown, so single line breaks and double spaces are meaningless and drop out. However, double linebreaks or those connected to other markdown syntax (e.g. bulleted lists) did have meaning. All should now be correct. Preview: https://deploy-preview-1035--fdc3.netlify.app/schemas/next/app-directory.html |
Co-authored-by: Hugh Troeger <troeger.hugh@gmail.com>
resolves #1033
builds on PR #1034
Converts the AppD schema file from YAML to JSON Schema (where the tooling is a little better and ensuring that we use one schema format across FDC3, where there are already other examples of JSON Schema use for contexts, bridging and bridging asyncAPI).
Updates were applied to to package scripts and the website to use the updated encoding.