Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction to the 2.0 IntentResult? #1107

Closed
openfin-johans opened this issue Nov 14, 2023 · 0 comments · Fixed by #1127
Closed

Correction to the 2.0 IntentResult? #1107

openfin-johans opened this issue Nov 14, 2023 · 0 comments · Fixed by #1127
Labels
api FDC3 API Working Group bug Something isn't working conformance Conformance testing framework formal specification

Comments

@openfin-johans
Copy link
Contributor

The IntentResult in 2.1 includes the following:

type IntentResult = Context | Channel | void;

This was meant to be the case for 2.0 as well but was somehow not added in all the right places during the implementation/documentation of 2.0:

https://fdc3.finos.org/docs/2.0/api/ref/Types#intentresult

The 2.0 Conformance tests actually check for this particular behaviour and even though it's no longer the active version - it make sense to update the docs and the NPM packages to line up with the original intention rather then having it as a change in 2.1.

https://github.com/finos/FDC3-conformance-framework/blob/main/src/test/v2.0/advanced/fdc3.raiseIntent-Result.ts#L23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api FDC3 API Working Group bug Something isn't working conformance Conformance testing framework formal specification
Projects
None yet
1 participant