Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard WG Meeting - November 30th, 2023 #1114

Closed
9 of 12 tasks
kriswest opened this issue Nov 29, 2023 · 13 comments
Closed
9 of 12 tasks

Standard WG Meeting - November 30th, 2023 #1114

kriswest opened this issue Nov 29, 2023 · 13 comments
Labels
indexed When a meeting attendance is being tracked meeting Standard WG Meeting

Comments

@kriswest
Copy link
Contributor

kriswest commented Nov 29, 2023

Date

Thursday 30 Nov 2023 - 10am (US eastern timezone EST) / 3pm (London, GMT)

Zoom info

  • Join Zoom Meeting
  • Meeting ID: 969 4029 4948
  • Passcode: 636931
  • Dial-in:
    Country International Dial-in Toll-free Dial-in
    US +1 929 205 6099 (New York) 877 853 5247
    UK +44 330 088 5830 0800 031 5717
    France +33 1 8699 5831 0 800 940 415
    Find your local number https://zoom.us/u/ad2WVnBzb8

Meeting notices

  • FINOS Project leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.

  • All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.

  • FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact legal@finos.org with any questions.

  • FINOS project meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.

Agenda

Minutes

  • Updating participant CLAs for the Community Spec License
    • An active CLA is required for meeting participation (as FDC3/FINOS considers meeting participation to constitute contribution)
    • @kriswest demonstrated how to check your CLA by opening a a dummy PR and requested all participants do so during the meeting - where a CLA for the new license is not present EasyCLA can then be used to sign a new one.
    • Meeting templates will be updated with information on this - and we'll cover it again at the next meeting in January
  • Multiple Language Bindings #990 and Proposal to add .NET interfaces and context declarations #931
    • Details were provided on how to review the proposed signatures and contribution issue and how it is proposed that governance will work (as a part of the FDC3 project itself, rather than a separate project)
      • There was consensus at the meeting that this was the right approach and should be used for these signature and others proposed for adoption.
      • Work is already underway (and ennearly complete according to @bingenito) on adding .NET signatures to the FDC3 documentation - when avaialble these will help enable further review
    • @kriswest, on behalf of the FDC3 maintainers, proposed @bingenito as an FDC3 maintainer (to support the .NET signatures, alongside a number of colleagues from his firm that will wor as contributors) and requested the SWG's consent, which was given.
  • FDC3 should avoid union types in contexts and other objects #1105
    • @bingenito & @kriswest discussed why union types are a problem for FDC3 implementations written in languages other than TypeScript and JSON Schema:
      • Its a type of polymorphism that is hard (or impossible, where unions with primitive types are used) to emulate in other languages.
      • It can sometimes be solved in API signatures via function/method overloads - but these can add both cognitive and code complexity or marker interfaces (an interface thats added to multiple classes, just so it can be used as a type)
    • There was consensus at the meeting that FDC3 must avoid such constructs whereever possible if its to be implemented in multiple languages
    • There was consensus that PR remove union type for chat message #1102 should go ahead and make a retrospective change to FDC3 2.1 to remove the union type that fdc3.chat.message contains
  • Correction to the 2.0 IntentResult? #1107
    • @openfin-johans & @kriswest described the issue: FDC3 2.0 had (what the authors consider) an error in it. It was intended that Intent handler be able to return void and that intentResolution.getResult() resolve to void. However, as written in the standard docs, an error would have to be thrown (as the IntentResult type does not include void). This was corrected in FDC3 2.1 and was implemented in the FDC3 2.0 conformance tests such that a void result is expected - hence, all FDC3 Desktop Agents that have been tested for 2.0 conformance (3) already use this approach. The proposal is to make a retropsective change to 2.0 to apply that correction.
      • There were no strong objections to doing so at the meeting. It was resolved to move this to a concrete PR and then re-check consensus on making the change.
  • @kriswest provided a brief overview of changes to the FDC3 NPM module (2.1.0-beta.4) and work underway to update its build (to be completed before the beta label is removed).
    • Feedback is desired from the community on the new module, which can be used with existing 2.0 Desktop Agent implementations.

Action Items

  • All meeting participants: raise a dummy PR (as demosntrated in the meeting) to check your CLA status - for most this will show 'not authorized' due to the FDC3 license update, click to be authorized and then follow the instructions to sign (or have your firm sign) the new CLA.
  • @fdc3-maintainers review and merge remove union type for chat message #1102
  • ALL test the FDC3 NPM module 2.1.0-beta.4 and report back on any issues - its should be compatible with all apps using the 2.0.x modules
  • @kriswest Implement a PR to resolve Correction to the 2.0 IntentResult? #1107

Untracked attendees

Full name Affiliation GitHub username
@bingenito
Copy link
Member

Brian Ingenito / Morgan Stanley

@novavi
Copy link

novavi commented Nov 30, 2023

Derek Novavi / S&P Global

@psmulovics
Copy link

Peter Smulovics / Morgan Stanley

@kriswest
Copy link
Contributor Author

Kris West / interop.io

@smocarski
Copy link

Steven Mocarski / OpenFIn

@lspiro-Tick42
Copy link

Leslie Spiro / Interop.io

@paulgoldsmith
Copy link

Paul Goldsmith / Morgan Stanley

@openfin-johans
Copy link
Contributor

Johan Sandersson / OpenFin 🎁

@mattjamieson
Copy link
Contributor

Matt Jamieson / WhiteDog

@kruplm
Copy link

kruplm commented Nov 30, 2023

Maria Krupl / Morgan Stanley

@hughtroeger
Copy link
Contributor

Hugh Troeger / FactSet

@timjenkel
Copy link

Tim Jenkel / Wellington

@mistryvinay
Copy link
Contributor

Vinay Mistry / Symphony 🎵

@github-actions github-actions bot added the indexed When a meeting attendance is being tracked label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
indexed When a meeting attendance is being tracked meeting Standard WG Meeting
Projects
None yet
Development

No branches or pull requests