Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update workbench for 2.1 #1103

Merged
merged 7 commits into from
Dec 16, 2023
Merged

Update workbench for 2.1 #1103

merged 7 commits into from
Dec 16, 2023

Conversation

kriswest
Copy link
Contributor

@kriswest kriswest commented Nov 10, 2023 •
edited
Loading

resolves #1087

  • Renames 2.0 version to 2.0+
  • Auto-select 2.0 version if 2.1 DA version is reported
  • Adds context templates for types added in 2.1
  • Adds an alert under addIntentListener to indicate that DAs may require intents to be added to the apps appD record to be usable
  • Adds intents standardized in 2.1

@netlify Netlify
Copy link

netlify bot commented Nov 10, 2023 •
edited
Loading

✅ Deploy Preview for fdc3 ready!

Name Link
🔨 Latest commit bdabe31
🔍 Latest deploy log https://app.netlify.com/sites/fdc3/deploys/657c9acee3be5a00085bba31
😎 Deploy Preview https://deploy-preview-1103--fdc3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kriswest kriswest mentioned this pull request Nov 29, 2023
Closed
12 tasks
@kriswest kriswest requested a review from bingenito December 4, 2023 10:43
@bingenito bingenito self-requested a review December 4, 2023 17:42
@kriswest
Copy link
Contributor Author

/easycla

@kriswest kriswest requested a review from bingenito December 15, 2023 18:36
hughtroeger
hughtroeger approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@hughtroeger hughtroeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out locally, everything looks good!

@kriswest kriswest merged commit 43ce7b2 into master Dec 16, 2023
10 checks passed
@kriswest kriswest deleted the update-workbench-for-2.1 branch December 16, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughtroeger hughtroeger hughtroeger approved these changes

@bingenito bingenito bingenito approved these changes

@mattjamieson mattjamieson Awaiting requested review from mattjamieson

@robmoffat robmoffat Awaiting requested review from robmoffat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update FDC3 workbench for FDC3 2.1
3 participants
@kriswest @bingenito @hughtroeger