Fixing a build error introduced by quicktype enums

[kriswest]

THe latest version of quicktype has started generating single value enums for constant values, which are causing issues in the context type tests (Context types serialize but cause type errors on deserialization). However, its also capable of generating const values - although this option hasn't been exposed correctly through the CLI (raising a PR to fix). Generating true const value fixes the issue.

I hadn't noticed this test failing when I merged:

• Upgrade quicktype and correct a schema error #1082
  This PR is needed to get the build passing again - although we also need a quicktype release to make it repeatable

Also resolving a critical vulnerability (babel) via npm audit fix

[netlify]

✅ Deploy Preview for fdc3 canceled.

Name	Link
🔨 Latest commit	7ac81ab
🔍 Latest deploy log	https://app.netlify.com/sites/fdc3/deploys/652e7e31ea9dfa0009f6915c

[kriswest]

Apologies @hughtroeger @mattjamieson, looks like the last PR I merged broke the test (npm run test) this fixes them again.

[kriswest]

QuickType PR for exposing the prefer-const-values setting: glideapps/quicktype#2426

To use a custom quicktype change s2tQuickTypeUtil.js to point quicktypeExec at the local version:

// Normalise path to local quicktype executable.
const quicktypeExec = "node " + ["..","quicktype","dist","index.js"].join(path.sep);
//const quicktypeExec = ['.', 'node_modules', '.bin', 'quicktype'].join(path.sep);

const command = `${quicktypeExec} --prefer-const-values --no-combine-classes -s schema -o ${outputFile} ${sources}`;

Current version:

FDC3/s2tQuicktypeUtil.js

Lines 43 to 46 in d127364

	// Normalise path to local quicktype executable.
	const quicktypeExec = ['.', 'node_modules', '.bin', 'quicktype'].join(path.sep);
	const command = `${quicktypeExec} --no-combine-classes -s schema -o ${outputFile} ${sources}`;

[kriswest]

This has not fixed the issue as the package scripts are regenerating the context types during the build step (by automatically calling preprepare). We'll either need to disable that or wait until Quicktype merges the option to expose the --prefer-const-values setting...

[kriswest]

Ok, its passing now - as long as the types are not regenerated. Here's hoping quicktype merge that PR soon

[hughtroeger]

Actually, why is there a package-lock.json change when the package.json doesn't have any changed dependencies? Is that intentional?

[kriswest]

Actually, why is there a package-lock.json change when the package.json doesn't have any changed dependencies? Is that intentional?

npm audit fix did that. Its basically the same set of changes to resolve a critical vulnerability that dependabot wants to make in this PR: #1089
I'm not sure why it overrides the resolutions in the lock file rather than updating the package.json - but we can do that manually...

[kriswest]

@hughtroeger its because is a transitive dependency, i.e. its coming in through tsdx, husky and jest:

PS C:\Users\Kris\Documents\code\FDC3> npm ls @babel/code-frame
@finos/fdc3@2.1.0-beta.3 C:\Users\Kris\Documents\code\FDC3
├─┬ husky@4.3.8
│ └─┬ cosmiconfig@7.1.0
│   └─┬ parse-json@5.2.0
│     └── @babel/code-frame@7.22.13 deduped
├─┬ jest-mock-extended@1.0.18
│ └─┬ jest@25.5.4
│   └─┬ @jest/core@25.5.4
│     └─┬ jest-message-util@25.5.0
│       └── @babel/code-frame@7.22.13 deduped
└─┬ tsdx@0.14.1
  ├─┬ @babel/core@7.21.4
  │ ├── @babel/code-frame@7.22.13
  │ └─┬ @babel/template@7.22.15
  │   └── @babel/code-frame@7.22.13 deduped
  ├─┬ @babel/traverse@7.23.2
  │ └── @babel/code-frame@7.22.13 deduped
  ├─┬ babel-eslint@10.1.0
  │ └── @babel/code-frame@7.22.13 deduped
  ├─┬ eslint@6.8.0
  │ └── @babel/code-frame@7.22.13 deduped
  └─┬ rollup-plugin-terser@5.3.1
    └── @babel/code-frame@7.22.13 deduped

It'll get sorted properly when we replace tsdx with something better maintained (see #1061)

[hughtroeger]

Ahh ok that makes sense. Looks good to me then.

[mattjamieson]

LGTM!