-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add algolia search to Docusaurus website #1163
Conversation
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me!
Would be good to get some other maintainers to review before merging. |
I find the results very confusing since they include all versions of the API (for example, search for 'addContextListener'. I'm not sure it makes sense to only index the latest version so maybe it points to the need of different page titles? |
Could turn on contextual search, which will filter to the currently displayed version: https://docusaurus.io/docs/search#contextual-search Otherwise, its a case of customisation and prominently displaying the version, and/or using custom facet filters. Probably best to try contextual search first as its easy to flip on |
let's give it a whirl. Just made the change |
+1 on this way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - it does a good job of breaking down the results into the major sections and filtering to a particular version (currently selected version) is working.
yeah this looks good - merge? |
sure - will leave the joy or pushing the button to you ;-) |
Too late, pushed the button myself |
Thanks for the PR @maoo and @robmoffat |
No description provided.