-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add content guidelines and other tweaks to community page #1169
Conversation
…y page and tweaks community categories
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@nkolba @robmoffat @finos/fdc3-maintainers Here's a crack at the discussed tweaks to the community page. I figured the easiest place to put the content guidelines is in the JSON file as that's what you see when you click on the "add your details" link. If this is good with you, then we need to merge it and just lightly tweak Nick's PR to set the right categories, etc. Happy to take suggestions on the guidelines, disclaimer etc., this is just an attempt to move us forward ;-) Preview link: https://deploy-preview-1169--fdc3.netlify.app/community |
P.S. Implementation filters need rewriting in react at some point. The community page is currently rendered by a react functional component then hacked by some old JS I wrote for the static version in the docusaurus 2 site. There should be some state for the selected filter, which is then used to filter the rendered entries and highlight the selected filter. The main downside currently is that the default filter is not shown as selected. Its possible it will develop other display artefacts later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this
From the last maintainers meeting:
Actions:
|
Adding Hugh's suggestions from review Co-authored-by: Hugh Troeger <htroeger@factset.com>
Updated to take care of outstanding objectives:
Ready to merge |
@nkolba This is merged now, so if you could merge into your PR and check the content categories that should be good to go too |
This PR: