Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content guidelines and other tweaks to community page #1169

Merged
merged 8 commits into from
Apr 10, 2024

Conversation

kriswest
Copy link
Contributor

@kriswest kriswest commented Mar 6, 2024

This PR:

  • adds content guidelines to the community data file,
  • adds a content disclaimer to the community page
  • adjusts the community page filter categories and recategorizes existing entries
    • "Examples and training" was split into "Tools and training" (training courses, software tools, conformance tests) and "Demos" (app and platform demos, getting started tools).
    • An "other" category was created for everything else (meetups, surveys, youtube videos etc.)
    • Adjusted margins on filter buttons (which became a bit spread out during docusaurus 2 update)
  • adds a few missing "Open Source" badges
  • stops the badges being clickable (just resets the scroll by reloading the page)
  • adopters moved become first and default filter,
  • removed the all filter,
  • ensured that a filter is always selected,
  • switched to a proper react implementation of filter to resolve oddities.

@kriswest kriswest requested review from robmoffat, nkolba and a team March 6, 2024 17:05
Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for fdc3 ready!

Name Link
🔨 Latest commit 53e5818
🔍 Latest deploy log https://app.netlify.com/sites/fdc3/deploys/66150fb10f62fa0008783092
😎 Deploy Preview https://deploy-preview-1169--fdc3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kriswest
Copy link
Contributor Author

kriswest commented Mar 6, 2024

@nkolba @robmoffat @finos/fdc3-maintainers Here's a crack at the discussed tweaks to the community page. I figured the easiest place to put the content guidelines is in the JSON file as that's what you see when you click on the "add your details" link.

If this is good with you, then we need to merge it and just lightly tweak Nick's PR to set the right categories, etc.

Happy to take suggestions on the guidelines, disclaimer etc., this is just an attempt to move us forward ;-)

Preview link: https://deploy-preview-1169--fdc3.netlify.app/community

@kriswest
Copy link
Contributor Author

kriswest commented Mar 6, 2024

P.S. Implementation filters need rewriting in react at some point. The community page is currently rendered by a react functional component then hacked by some old JS I wrote for the static version in the docusaurus 2 site. There should be some state for the selected filter, which is then used to filter the rendered entries and highlight the selected filter.

The main downside currently is that the default filter is not shown as selected. Its possible it will develop other display artefacts later.

Copy link
Member

@bingenito bingenito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this

website/data/community.json Outdated Show resolved Hide resolved
@kriswest kriswest requested a review from a team March 12, 2024 11:39
@kriswest
Copy link
Contributor Author

From the last maintainers meeting:

  • Community page PR and content guidelines
    • All ok with content guidelines etc.
    • Still a problem with multiple entries clustering by alpha sort
      • Consider selecting a category/eliminating all filter
      • Move adopters to be first category
      • Encourage more adopter entries - we've got many super involved firms not listed: Citi, Morgan Stanley, RBC, Wellington etc., could add big name app providers too (if multi-entry problem solved) e.g. Factset and Symphony. The goal of this whole page and specifically the adopters section is to show engagement with FDC3 so its where we need to focus efforts
        • Consider sending out proposed entries, odds are they will correct and send back faster than we get them to originate one...

Actions:

  • (Kris) Take community PR a bit further if possible - adopters to become first section, remove all filter, ensure a filter is selected by default, switch to proper react implementation of filter to resolve oddities.

@kriswest kriswest self-assigned this Mar 20, 2024
website/data/community.json Outdated Show resolved Hide resolved
website/data/community.json Outdated Show resolved Hide resolved
website/data/community.json Outdated Show resolved Hide resolved
website/data/community.json Outdated Show resolved Hide resolved
website/data/community.json Outdated Show resolved Hide resolved
website/src/css/customTheme.css Outdated Show resolved Hide resolved
Adding Hugh's suggestions from review

Co-authored-by: Hugh Troeger <htroeger@factset.com>
@kriswest
Copy link
Contributor Author

kriswest commented Apr 9, 2024

Updated to take care of outstanding objectives:

  • adopters to become first section,
  • remove all filter,
  • ensure a filter is selected by default,
  • switch to proper react implementation of filter to resolve oddities.

Ready to merge

@kriswest kriswest merged commit d525bd5 into main Apr 10, 2024
9 checks passed
@kriswest kriswest deleted the tweak-community-page branch April 10, 2024 13:27
@kriswest
Copy link
Contributor Author

@nkolba This is merged now, so if you could merge into your PR and check the content categories that should be good to go too

@kriswest kriswest mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants