Don't use union types in context and API definitions #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext-definitions Docs additions for avoiding union types - moving to FINOS repo
✅ Deploy Preview for fdc3 canceled.
|
kriswest
commented
Apr 29, 2024
14 tasks
kriswest
changed the title
…//github.com/finos/FDC3 into don't-use-union-types-in-context-definitions
hughtroeger
reviewed
Apr 29, 2024
Co-authored-by: Hugh Troeger <htroeger@factset.com>
10 tasks
bingenito
reviewed
May 8, 2024
bingenito
approved these changes
May 8, 2024
bingenito
approved these changes
May 8, 2024
hughtroeger
approved these changes
May 28, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1105
Adds content to the Context and API overviews about not using unions types (particularly of primitive types) as they are not easily implementable in other languages.
Preview deeplinks: