Corrections to #1207 to fix broken tests #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@bingenito @finos/fdc3-maintainers here's a great example of why the tests should be required to pass before a PR can be merged. Somehow 4 of us looked at this and didn't see the npm-build tests failing! That's probably because they have not run and there was no failure to see: https://github.com/finos/FDC3/actions/workflows/package.yml?query=is%3Afailure |
hughtroeger
approved these changes
Jun 27, 2024
hughtroeger
approved these changes
Jun 27, 2024
bingenito
approved these changes
Jun 27, 2024
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1234 by correcting deprecated JEST config
resolves #1235 by adding missing addEventListener function to Methods.ts