Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StepSecurity] ci: Harden GitHub Actions (Token Permissions) #1246

Merged

Conversation

step-security-bot
Copy link
Contributor

Summary

This pull request is created by StepSecurity at the request of @bingenito. Please merge the Pull Request to incorporate the requested changes. Please tag @bingenito on your message if you have any questions related to the PR.
Fixes #1244

Security Fixes

Least Privileged GitHub Actions Token Permissions

The GITHUB_TOKEN is an automatically generated secret to make authenticated calls to the GitHub API. GitHub recommends setting minimum token permissions for the GITHUB_TOKEN.

Feedback

For bug reports, feature requests, and general feedback; please email support@stepsecurity.io. To create such PRs, please visit https://app.stepsecurity.io/securerepo.

Signed-off-by: StepSecurity Bot bot@stepsecurity.io

Signed-off-by: StepSecurity Bot <bot@stepsecurity.io>
Copy link

CLA Not Signed

Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for fdc3 ready!

Name Link
🔨 Latest commit eff1822
🔍 Latest deploy log https://app.netlify.com/sites/fdc3/deploys/668529d77dfec10008a7a21c
😎 Deploy Preview https://deploy-preview-1246--fdc3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bingenito bingenito requested review from robmoffat and a team July 3, 2024 10:41
@bingenito bingenito changed the title [StepSecurity] ci: Harden GitHub Actions [StepSecurity] ci: Harden GitHub Actions (Token Permissions) Jul 3, 2024
Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although we'll need to check the pacakging workflow is still able to publish to github after this merged. That will only be triggered when we try to push a new module version to NPM.

@bingenito bingenito merged commit 6d2f9fa into finos:main Jul 4, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update actions to default of least privilege
3 participants