Set explicit background colours for website #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Any thoughts on a bit lighter for dark theme like #1b1b1d? You can see with dark theme on docusaurus.io for an example. |
bingenito
previously approved these changes
Sep 19, 2024
kriswest
commented
Sep 19, 2024
kriswest
commented
Sep 19, 2024
Adjust colours
|
@bingenito adjusted to #1b1b1b, does seem a little less stark |
bingenito
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The website doesn't currently explicitly set background colors - rather it assume the browser's default background is white (which is a user preference in some browsers, while many electron-based products use a dark background by default - leaving the page impossible to read).
This PR sets an explicit background colour for each mode (dark and light)