Creating a PR template #1412
Merged
Creating a PR template #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fdc3 canceled.
|
bingenito
previously approved these changes
Nov 4, 2024
bingenito
reviewed
Nov 4, 2024
Co-authored-by: Brian Ingenito <28159742+bingenito@users.noreply.github.com>
kriswest
commented
Nov 11, 2024
Co-authored-by: kemerava <52539182+kemerava@users.noreply.github.com>
|
@kemerava dealt with comments - which prompted me to add sections on context and intent types if you want to take another look. |
bingenito
reviewed
Nov 11, 2024
bingenito
reviewed
Nov 11, 2024
bingenito
reviewed
Nov 11, 2024
Co-authored-by: Brian Ingenito <brian.ingenito@morganstanley.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at a PR template for FDC3. Should be updated to include code locations in the fdc3-for-web-impl PR which refactors the repository.
Please note that the comments wrapped
<!--- -->do not render in PR pages, but are visible when creating or editing the PR description. They are provided to help explain the template to contriboutors. See: https://github.com/finos/FDC3/blob/PR-template/.github/pull_request_template.md for a preview