Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move addon package to toolbox/fdc3-for-web/reference-ui #1428

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

julianna-ciq
Copy link
Contributor

No description provided.

@julianna-ciq julianna-ciq requested a review from a team as a code owner November 12, 2024 16:38
Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted a few out of date message names (which may not be the subject of this PR - but they were edited in this one so thought to point out). I'm also uncertain about the build outputting directly into the website's static dir. It might be better to output within the reference-ui project then copy to website location.

toolbox/fdc3-for-web/reference-ui/src/channel_selector.ts Outdated Show resolved Hide resolved
toolbox/fdc3-for-web/reference-ui/src/intent_resolver.ts Outdated Show resolved Hide resolved
toolbox/fdc3-for-web/reference-ui/vite.config.ts Outdated Show resolved Hide resolved
@robmoffat robmoffat merged commit dd5e1c7 into finos:fdc3-for-web-impl Nov 15, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants