Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match event listener names to event type names in fdc3 for web schemas #1459

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions schemas/api/common.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@
"description": "Event listener type names for Private Channel events.",
"type": "string",
"enum": [
"onAddContextListener",
"onUnsubscribe",
"onDisconnect"
"addContextListener",
"unsubscribe",
"disconnect"
]
}
}
Expand Down
12 changes: 6 additions & 6 deletions src/api/BrowserTypes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1442,7 +1442,7 @@ export interface AppMetadata {
}

/**
* Describes an Icon images that may be used to represent the application.
* Describes an Icon image that may be used to represent the application.
*/
export interface Icon {
/**
Expand Down Expand Up @@ -2107,7 +2107,7 @@ export interface GetCurrentContextResponsePayload {
*/

/**
* Request to retrieve information about the FDC3 Desktop Agent implementation and the
* Request to retrieve information about the FDC3 Desktop Agent implementation and the
* metadata of the calling application according to the Desktop Agent.
*
* A request message from an FDC3-enabled app to a Desktop Agent.
Expand Down Expand Up @@ -2919,7 +2919,7 @@ export interface TPayload {
*
* Event listener type names for Private Channel events.
*/
export type PrivateChannelEventListenerTypes = "onAddContextListener" | "onUnsubscribe" | "onDisconnect";
export type PrivateChannelEventListenerTypes = "addContextListener" | "unsubscribe" | "disconnect";

/**
* Identifies the type of the message and it is typically set to the FDC3 function name that
Expand Down Expand Up @@ -5780,9 +5780,9 @@ const typeMap: any = {
"openResponse",
],
"PrivateChannelEventListenerTypes": [
"onAddContextListener",
"onDisconnect",
"onUnsubscribe",
"addContextListener",
"disconnect",
"unsubscribe",
],
"PrivateChannelAddEventListenerRequestType": [
"privateChannelAddEventListenerRequest",
Expand Down
Loading