1.1 api simple #154
1.1 api simple #154
Conversation
|
thanks @rikoe! I've made the recommended changes and pushed to my branch |
| * `Error` with a string from the `ChannelError` enumeration. | ||
| */ | ||
| joinChannel(channelId: string) : Promise<void>; |
There was a problem hiding this comment.
All other channel interactions happen through the Channel object, and for consistency it feels like this one should too.
Can this method be moved to Channel.join(): Promise<void>?
There was a problem hiding this comment.
I think the reason is that if it is at the top level you could just join a channel by id without having to do a “get and search” first, so it massively simplifies the code for someone who just wants to join a channel and then use the existing top-level broadcast or context listener.
| * Channels may be visualized and selectable by users. DisplayMetaData may be used to provide hints on how to see them. | ||
| * For app channels, displayMetadata would typically not be present | ||
| */ | ||
| displayMetadata?: DisplayMetadata; |
There was a problem hiding this comment.
Add public readonly modifiers?
Also, comment refers to "DisplayMetaData", should be "DisplayMetadata".
|
|
||
| try { | ||
| let myChannel = await fdc3.getOrCreateChannel("myChannel"); | ||
| myChannel.addContextListener(listener); |
There was a problem hiding this comment.
This is not correct. Should be: const listener = myChannel.addContextListener(context => { })
The purpose of this pull request is the following: