Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spec): add deprecation notices to API spec #341

Merged
merged 2 commits into from
Mar 9, 2021

Conversation

rikoe
Copy link
Contributor

@rikoe rikoe commented Mar 8, 2021

  • deprecation of 'global' channel
  • deprecation of IntentResolution.data property

Relates to #326

@rikoe rikoe force-pushed the spec-deprecation-notice branch from 60a5e47 to dbabd3b Compare March 8, 2021 23:06
- deprecation of 'global' channel
- deprecation of IntentResolution.data property

Relates to finos#326
@rikoe rikoe force-pushed the spec-deprecation-notice branch from dbabd3b to 9e68e70 Compare March 8, 2021 23:09
@rikoe rikoe requested review from kriswest and nkolba March 8, 2021 23:27
Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I had one suggestion that you can incorporate (as I think it's cleaner) or leave at your discretion.

docs/api/spec.md Outdated Show resolved Hide resolved
docs/api/spec.md Outdated Show resolved Hide resolved
@rikoe rikoe merged commit 45f1e4b into finos:master Mar 9, 2021
@rikoe rikoe deleted the spec-deprecation-notice branch March 9, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants