Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

430 Rename System channels User channels to reflect usage #479

Merged
merged 16 commits into from
Feb 21, 2022
Merged

430 Rename System channels User channels to reflect usage #479

merged 16 commits into from
Feb 21, 2022

Conversation

kriswest
Copy link
Contributor

resolves #430

Changes:

  • Replaces 'System channels' with 'User channels' through the spec, documentation, API and methods.ts.
  • Clarifies spec and documentation where it is referring to User channels vs. App channels
  • Adds support to methods.ts for automatically falling back to getSystemChannels if getUserChannels doesn't exist

@kriswest kriswest requested a review from a team October 15, 2021 17:40
@kriswest kriswest added api FDC3 API Working Group docs Documentation labels Oct 15, 2021
@kriswest kriswest mentioned this pull request Oct 22, 2021
Closed
11 tasks
@kriswest kriswest mentioned this pull request Nov 4, 2021
Closed
14 tasks
@kriswest
Copy link
Contributor Author

kriswest commented Nov 9, 2021 •
edited
Loading

Needs changelog entry adding

This was referenced Nov 15, 2021
Closed
Closed
@kriswest kriswest added enhancement New feature or request channels feeds & transactions Channels, Feeds & Transactions Discussion Group and removed docs Documentation labels Nov 22, 2021
@kriswest kriswest changed the title Rename System channels User channels to reflect usage 430 Rename System channels User channels to reflect usage Nov 26, 2021
mattjamieson
mattjamieson requested changes Dec 21, 2021
View reviewed changes
docs/api/spec.md Outdated Show resolved Hide resolved
docs/api/spec.md Outdated Show resolved Hide resolved
docs/api/spec.md Outdated Show resolved Hide resolved
docs/api/spec.md Outdated Show resolved Hide resolved
kriswest and others added 2 commits December 21, 2021 10:41
@kriswest @mattjamieson
Apply suggestions from code review
c8a66a3 
Co-authored-by: Matt Jamieson <10372+mattjamieson@users.noreply.github.com>
@kriswest
Merge branch 'master' into 430-rename-system-channels-user-channels
1625a55
rikoe
rikoe approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@rikoe rikoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

docs/context/ref/InstrumentList.md Outdated
@@ -54,7 +54,7 @@ const instruments = {
]
}

fdc3.joinChannel('global')
fdc3.joinUserChannel('global')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be changed from global to another channel name, but can be handled separately from this PR.

@kriswest kriswest requested a review from hughtroeger February 4, 2022 11:26
@kriswest
Copy link
Contributor Author

kriswest commented Feb 4, 2022 •
edited
Loading

@greyseer256 I'll merge this one after you've had a chance to take a look, it has the necessary other reviews.

kriswest
kriswest commented Feb 4, 2022
View reviewed changes
src/api/DesktopAgent.ts Outdated Show resolved Hide resolved
hughtroeger
hughtroeger reviewed Feb 4, 2022
View reviewed changes
docs/api/ref/DesktopAgent.md Show resolved Hide resolved
docs/api/ref/Errors.md Outdated Show resolved Hide resolved
docs/api/spec.md Outdated Show resolved Hide resolved
test/Methods.test.ts Outdated Show resolved Hide resolved
@kriswest kriswest merged commit d9c0352 into finos:master Feb 21, 2022
@kriswest kriswest deleted the 430-rename-system-channels-user-channels branch February 21, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughtroeger hughtroeger hughtroeger left review comments

@ggeorgievx ggeorgievx ggeorgievx approved these changes

@rikoe rikoe rikoe approved these changes

@mattjamieson mattjamieson mattjamieson approved these changes

@donbasuno donbasuno Awaiting requested review from donbasuno

Assignees
No one assigned
Labels
api FDC3 API Working Group channels feeds & transactions Channels, Feeds & Transactions Discussion Group cla-present enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename 'System Channels' 'User Channels'
5 participants
@kriswest @mattjamieson @rikoe @hughtroeger @ggeorgievx