Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Governance and licensing updates #485
Governance and licensing updates #485
Changes from all commits
a401785
984ed4f
fd627d7
616e9fb
0c7e330
e1ca674
8d6740c
9516148
adde479
78e72c9
5351641
70c1c51
1789200
b2946a3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'approval' referred to is essentially review by the maintainers, who are supposed to try and apply a consensus-based decision from the SWG.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Languages changes @RexJaeschke recommends also need to be applied here, see:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re the use of "S/specification," our current thinking is to use "Standard" and that "Specification" (uppercase) not be used. Kris has come up with new section names that eliminate such uses of. That said, we could revert to "Specification" instead, but should think that through a bit. Then there is the question of whether we should ever use "specification" (lowercase) anywhere regardless of the previous sentence outcome. The original confusion for me arose from the use of "Specification" in section headers, which suggested they were part of the requirements while other sections without that were not, simply because of the implicit understanding of what "Specification" means.
FWIW, ISO requires "Specification" rather than "Standard."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copiesofcopies I think I was still slightly off (I realised after reading @scooter99boston's clarification). Rather, our process is:
While writing this I spotted a further issue:
I don't know what "the Scope" is or where it's defined as that document (from the Standards Project Blueprint) is not part of this PR. The scope is defined in the FDC3 Charter here: https://fdc3.finos.org/docs/fdc3-charter
Perhaps we should pull that content in to create the scope document OR refer out to it. If we're trying to head towards the full CSL I would suggest the former is the way to go. Do you agree?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copiesofcopies as its referred to, should we bring in the scope doc (from the Standards Project Blueprint) and populate with details from https://fdc3.finos.org/docs/fdc3-charter ?
Can you do that or should I raise a PR (into yours?) to do so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kriswest thanks for catching this. I think it makes sense to include a scope file as you suggested. I've added a proposed scope to the pull request, incorporating the FDC3 mission (with minor changes to adapt it to the purpose) and scope (unchanged).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks @copiesofcopies.
I've raised a separate issue, #529, to cover adding a description of how we implement this governance to the README and website - hence I think this is now good to go!