431 Making joinChannel, leaveCurrentChannel and getCurrentChannel functions optional #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriswest
added
enhancement
kriswest
requested review from
mattjamieson,
thorsent,
rikoe,
donbasuno and
ggeorgievx
11 tasks
kriswest
commented
Dec 13, 2021
kriswest
commented
Dec 13, 2021
mattjamieson
requested changes
Dec 21, 2021
Co-authored-by: Matt Jamieson <10372+mattjamieson@users.noreply.github.com>
mattjamieson
approved these changes
Jan 6, 2022
hughtroeger
approved these changes
Jan 26, 2022
ggeorgievx
approved these changes
Jan 27, 2022
kriswest
deleted the
431-make-joinChannel-leaveCurrentChannel-optional
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #431
Making joinChannel, leaveCurrentChannel and getCurrentChannel functions optional for FDC3 API compliance, but are recommended through the application of the SHOULD keyword.