Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ViewHoldings intent #541

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Add ViewHoldings intent #541

merged 1 commit into from
Feb 24, 2022

Conversation

rikoe
Copy link
Contributor

@rikoe rikoe commented Jan 11, 2022

  • Add new intent documentation page and include in sidebar.
  • Add to Intents enumeration for npm package.
  • Add to standard intents JSON file.

Note that this doesn't add an OrganizationList context type as suggested in the issue, it is best considered separately.

image

Resolves #497

@rikoe
feat: Add ViewHoldings intent (finos#497)
e966570 
- Add new intent documentation page and include in sidebar.
- Add to Intents enumeration for npm package.
- Add to standard intents JSON file.

Resolves finos#497
@rikoe rikoe added the Context Data & Intents Contexts & Intents Discussion Group label Jan 11, 2022
@rikoe rikoe added this to the 2.0-candidates milestone Jan 11, 2022
@rikoe rikoe requested a review from a team January 11, 2022 13:03
@rikoe rikoe mentioned this pull request Jan 11, 2022
Closed
9 tasks
kriswest
kriswest approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only issue I note is that this hasn't been added t the list in docs\intents\spec.md. However, that list is redundant with the navigation and could be dropped entirely as we expand the list.

@kriswest kriswest mentioned this pull request Feb 7, 2022
Closed
10 tasks
@kriswest kriswest requested a review from a team February 15, 2022 13:30
@kriswest kriswest mentioned this pull request Feb 21, 2022
Closed
15 tasks
@kriswest kriswest modified the milestones: 2.0-candidates, 2.0 Feb 24, 2022
@kriswest kriswest merged commit 7bd4850 into finos:master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kriswest kriswest kriswest approved these changes

@hughtroeger hughtroeger hughtroeger approved these changes

Assignees
No one assigned
Labels
Context Data & Intents Contexts & Intents Discussion Group
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

ViewHoldings Intent
3 participants
@rikoe @kriswest @hughtroeger