Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

555 556 558 re-write of the AppD overview page #570

Conversation

kriswest
Copy link
Contributor

@kriswest kriswest commented Jan 26, 2022

resolves #555, resolves #558, resolves #556

Re-write of the AppD overview page with the intention to better introduce the role and value of the AppD. The relationship between AppD records and other manifest formats is also clarified.

Copy link
Contributor

@hughtroeger hughtroeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, looks good.

docs/app-directory/overview.md Outdated Show resolved Hide resolved
docs/app-directory/overview.md Outdated Show resolved Hide resolved
Co-authored-by: Hugh Troeger <troeger.hugh@gmail.com>
@kriswest kriswest requested a review from mistryvinay March 16, 2022 13:07
Copy link
Contributor

@openfin-johans openfin-johans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but suggested some rephrasing. Happy to discuss.

docs/app-directory/overview.md Outdated Show resolved Hide resolved
docs/app-directory/overview.md Outdated Show resolved Hide resolved
docs/app-directory/overview.md Outdated Show resolved Hide resolved
docs/app-directory/overview.md Outdated Show resolved Hide resolved
Co-authored-by: openfin-johans <98814236+openfin-johans@users.noreply.github.com>
@kriswest
Copy link
Contributor Author

kriswest commented Apr 1, 2022

Merged suggested changes @openfin-johans

@kriswest kriswest changed the title 555 558 re-write of the AppD overview page 555 556 558 re-write of the AppD overview page Apr 4, 2022
@kriswest kriswest requested a review from hughtroeger April 4, 2022 12:31
@kriswest
Copy link
Contributor Author

kriswest commented Apr 4, 2022

@kriswest kriswest changed the base branch from master to Appd-consolidated-update-branch April 20, 2022 14:36
@kriswest
Copy link
Contributor Author

@greyseer256 think I only need your (re)review for this then will merge into the consolidated branch (there will be further review of that in future)

Copy link
Contributor

@openfin-johans openfin-johans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late response to the remaining issue...

docs/app-directory/overview.md Outdated Show resolved Hide resolved
Co-authored-by: openfin-johans <98814236+openfin-johans@users.noreply.github.com>
@kriswest kriswest merged commit 8362832 into finos:Appd-consolidated-update-branch Apr 22, 2022
@kriswest kriswest deleted the 555-558-improve-AppD-overview branch May 20, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants