Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

581 add intent delivery failed error and document errors #601

Conversation

kriswest
Copy link
Contributor

resolves #581 by adding a new IntentDeliveryFailed error
Also:

  • Adds documentation of the intended use of each error
  • Removes unnecessary copyright dates from source files (the years is not being updated when changes are made and the github repo already timestamps when content was added in its revision history)

Copy link
Contributor

@mattjamieson mattjamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Added suggestions to fix a few typos.

CHANGELOG.md Outdated Show resolved Hide resolved
docs/api/ref/Errors.md Outdated Show resolved Hide resolved
src/api/Errors.ts Outdated Show resolved Hide resolved
Co-authored-by: Matt Jamieson <10372+mattjamieson@users.noreply.github.com>
@kriswest kriswest requested a review from mattjamieson March 1, 2022 10:41
@kriswest
Copy link
Contributor Author

kriswest commented Mar 1, 2022

Thanks @mattjamieson, suggestions applied

@kriswest kriswest added api FDC3 API Working Group enhancement New feature or request labels Mar 2, 2022
@kriswest kriswest added this to the 2.0 milestone Mar 2, 2022
docs/api/ref/Errors.md Outdated Show resolved Hide resolved
docs/api/ref/Errors.md Outdated Show resolved Hide resolved
docs/api/ref/Errors.md Outdated Show resolved Hide resolved
docs/api/ref/Errors.md Outdated Show resolved Hide resolved
docs/api/ref/Errors.md Outdated Show resolved Hide resolved
src/api/Errors.ts Outdated Show resolved Hide resolved
src/api/Errors.ts Outdated Show resolved Hide resolved
src/api/Errors.ts Outdated Show resolved Hide resolved
src/api/Errors.ts Outdated Show resolved Hide resolved
docs/api/ref/Errors.md Outdated Show resolved Hide resolved
src/api/Errors.ts Outdated Show resolved Hide resolved
Co-authored-by: Hugh Troeger <troeger.hugh@gmail.com>
@kriswest
Copy link
Contributor Author

kriswest commented Mar 3, 2022

Suggestions applied @greyseer256, thanks again

src/api/Errors.ts Outdated Show resolved Hide resolved
@kriswest kriswest merged commit 7699b00 into finos:master Mar 11, 2022
@kriswest kriswest deleted the 581-add-IntentDeliveryFailed-error-and-document-errors branch March 11, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api FDC3 API Working Group enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an error to ResolveError for failure to deliver an intent to an app
3 participants