Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

588 intent proposal ViewOrders #672

Merged
merged 1 commit into from
May 23, 2022
Merged

588 intent proposal ViewOrders #672

merged 1 commit into from
May 23, 2022

Conversation

pauldyson
Copy link
Contributor

@pauldyson pauldyson commented Apr 22, 2022 •
edited by kriswest
Loading

resolves #588

@kriswest kriswest added Context Data & Intents Contexts & Intents Discussion Group intents labels Apr 22, 2022
@kriswest kriswest requested review from hughtroeger and a team April 22, 2022 10:30
@kriswest kriswest added the enhancement New feature or request label Apr 22, 2022
@kriswest kriswest requested a review from mistryvinay May 11, 2022 10:26
@kriswest kriswest changed the title View Orders PR. This commit closes #588 588 View Orders May 11, 2022
kriswest
kriswest approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - needs a CHANGELOG.md entry

@kriswest kriswest mentioned this pull request May 11, 2022
Closed
29 tasks
@kriswest kriswest changed the title 588 View Orders 588 intent proposal ViewOrders May 11, 2022
@kriswest kriswest added this to the 2.0-candidates milestone May 17, 2022
@mistryvinay mistryvinay changed the base branch from master to context-data-and-intents-consolidated-update-branch May 23, 2022 15:02
mistryvinay added a commit that referenced this pull request May 23, 2022
@mistryvinay
Merge branch 'pauldyson-588_intent_proposal_view_orders' into context…
9223b88 
…-data-and-intents-consolidated-update-branch

Merging PR #672 into consolidated PR branch
@mistryvinay mistryvinay merged commit fb6d4f6 into finos:context-data-and-intents-consolidated-update-branch May 23, 2022
mistryvinay
mistryvinay reviewed May 23, 2022
View reviewed changes
Copy link
Contributor

@mistryvinay mistryvinay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Added CHANGELOG.md entry as well.

@mistryvinay mistryvinay mentioned this pull request May 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistryvinay mistryvinay mistryvinay left review comments

@hughtroeger hughtroeger hughtroeger approved these changes

@kriswest kriswest kriswest approved these changes

Assignees
No one assigned
Labels
Context Data & Intents Contexts & Intents Discussion Group enhancement New feature or request intents
Projects
None yet
Milestone
2.0-candidates
Development

Successfully merging this pull request may close these issues.

Intent Proposal: ViewOrders
4 participants
@pauldyson @kriswest @mistryvinay @hughtroeger