Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

681 Update Intent Naming Conventions #701

Conversation

mistryvinay
Copy link
Contributor

Update Intent Naming Conventions

@mistryvinay mistryvinay changed the title Update Intent Naming Conventions #681 Update Intent Naming Conventions May 9, 2022
Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Vinay, good start. I've added some suggested changes

A changelog entry is also needed in CHANGELOG.md





## Initial Set of Standard Intents ##
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need this anymore and could replace with a comment that standardized intents are defined in the following pages, otherwise just cut it down to a bulleted list with each entry having a link to the relevant page...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kriswest is there a way to have a directory of the Ref/ folde? As this will allow future intents to appear as and when they are added?

As currently I need to include a hyperlink for each definition.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've got the sidebar nav, but thats all. Hence, we either remove the list and just mention that the individual types are on subsequent pages, or manually add a link for each...

It would be fine (and probably easier) to do this all in a subsequent PR when we've got the full set of intent and context PRs lined up.

@kriswest kriswest added docs Documentation intents Context Data & Intents Contexts & Intents Discussion Group labels May 11, 2022
@kriswest kriswest linked an issue May 11, 2022 that may be closed by this pull request
@kriswest kriswest changed the title #681 Update Intent Naming Conventions 681 Update Intent Naming Conventions May 11, 2022
mistryvinay and others added 8 commits May 12, 2022 11:12
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Kris West <kris@cosaic.io>
Co-authored-by: Kris West <kris@cosaic.io>
Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robmoffat
Copy link
Member

I think you should go further with the namespacing. I think that each intent should have a proper namespaced ID, and a display name.

  • fdc3. is reserved for standardised FDC3 intents.
  • anything else should be a domain that you own e.g. com.google.some.intent. (if it were google creating the intent).

I am not sure how this would affect intent resolution. It's possible that there could be multiple intents with the same English name.

This means if two apps are implementing the same intent, it's very clear, rather than just an accidental collision.

I am willing to accept that I might be completely off with this.. just wanted to know if it'd been discussed.

@kriswest
Copy link
Contributor

@robmoffat Namespacing has been discussed previously. The standardized intents are not currently namespaced - adding that to them would of course be a breaking change and it was deemed unnecessary. There's also a long-standing issues in the API and appD (e.g. #312) regarding intent display names (currently configured by each app, which doesn't make sense) meaning having them bare/human readable can actually be useful. It also differentiates them slightly from context type names.

That leaves us with only optional namespacing for proprietary intents which is there purely to differentiate a proprietary intent and avoid collision, where the rest of the time you want people to be reusing the same intents and contexts to promote uptake of common workflows and interchangeability of components/widespread interop of applications.

All that said, I would prefer a situation where display names were sorted out and we could be using true IDs. However I think that's a different issue and we should pick up and deal with this on:

@mistryvinay mistryvinay changed the base branch from master to context-data-and-intents-consolidated-update-branch May 17, 2022 11:42
@mistryvinay mistryvinay merged commit b3829bc into finos:context-data-and-intents-consolidated-update-branch May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Context Data & Intents Contexts & Intents Discussion Group docs Documentation intents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intent naming conventions
3 participants