Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

247 appd use of interop #731

Merged
merged 13 commits into from
Jun 6, 2022
Merged

247 appd use of interop #731

merged 13 commits into from
Jun 6, 2022

Conversation

kriswest
Copy link
Contributor

resolves #247

Adds a set of fields to AppD application records to describe an app's use of FDC3 and enable search for apps that 'interoperate' with a selected app.

@netlify
Copy link

netlify bot commented May 23, 2022

Deploy Preview for lambent-kulfi-cf51a7 ready!

Name Link
🔨 Latest commit acdca74
🔍 Latest deploy log https://app.netlify.com/sites/lambent-kulfi-cf51a7/deploys/629e1845892d1d00085ffdd5
😎 Deploy Preview https://deploy-preview-731--lambent-kulfi-cf51a7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kriswest kriswest added this to the 2.0-candidates milestone May 23, 2022
@kriswest kriswest changed the base branch from master to Appd-consolidated-update-branch May 23, 2022 16:40
CHANGELOG.md Outdated Show resolved Hide resolved
@kriswest
Copy link
Contributor Author

After a couple of false starts, this now has a preview at: https://deploy-preview-731--lambent-kulfi-cf51a7.netlify.app/schemas/next/app-directory#tag/Application/paths/~1v2~1apps~1{appId}/get

image

I'll add an example that uses it before release (not FDC3Workbench as its use is dynamic making it a poor example for these fields).

@nkolba do you prefer this to the previous version (with an interopUse field that wrapped these fields). I think it better now that they are siblings of intents.

Copy link
Contributor

@hughtroeger hughtroeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine, just not sure about the capitalization of 'application'

RaiseIntent:
type: object
description: >-
Optional metadata that describes which Intents are raised by the application and context types they are
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is mixed capitalization of 'application' in these descriptions, I'm not sure which we want to go with.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Lowercase in content, uppercase in Application Directory

@kriswest kriswest mentioned this pull request May 26, 2022
17 tasks
@kriswest
Copy link
Contributor Author

kriswest commented May 26, 2022

Latest preview with examples: https://deploy-preview-731--lambent-kulfi-cf51a7.netlify.app/schemas/next/app-directory#tag/Application/

@nkolba
and here is a screenie of the relevant section of the example:
image

Base automatically changed from Appd-consolidated-update-branch to master May 27, 2022 10:30
@kriswest kriswest modified the milestones: 2.0-candidates, 2.0 May 27, 2022
@kriswest
Copy link
Contributor Author

kriswest commented May 30, 2022

I've had a request to rename interopMeta to interop, which I'm fine with and actually prefer (as the whole record is metadata meta seems a little redundant). I've checked in with @nkolba on this (who suggested the current name) who is also fine with it (shorter names are good).

The original intention was to reinforce the non-binding aspects of this metadata (although the intent listening metadata is binding, the rest is not directly used by the desktop agent).

Hence, if there are no objections, I'll update the PR with this small change.
@openfin-gavin

@kriswest
Copy link
Contributor Author

kriswest commented Jun 6, 2022

Approved via email vote:

Minor change to the name of the element to be applied (interopMeta -> interop).

@kriswest kriswest merged commit 52f4f0b into master Jun 6, 2022
@kriswest kriswest deleted the 247-appd-use-of-interop branch June 6, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-directory enhancement New feature or request
Projects
None yet
3 participants