561 replace AppMetadata images field with screenshots, to match appD changes #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriswest
requested review from
mattjamieson,
nkolba,
rikoe,
mistryvinay,
donbasuno,
hughtroeger,
ggeorgievx and
a team
✅ Deploy Preview for lambent-kulfi-cf51a7 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
hughtroeger
approved these changes
Jun 6, 2022
rikoe
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR to resolve #561 did not update the
AppMetadataobject to keep it in sync with the App Directory record. Specifically, theimagesproperty was not replaced with ascreenshotsproperty:This PR applies a matching change to
AppMetadatato keep them in sync.N.B. there are many other fields that are not passed through to
AppMetadata(e.g.lang,categories,moreInfo,localizedVersions) which should be considered for addition to this type.