-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix vulnerable deps in FDC3 workbench #816
fix vulnerable deps in FDC3 workbench #816
Conversation
✅ Deploy Preview for lambent-kulfi-cf51a7 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hold on this, there's still an issue as the github action for website build is using old node versions and the website scripts use yarn one of both of which are causing the deps to be resolved differently which is breaking the website build. I'll have a look at those tomorrow and try again. |
@robmoffat It's working now - the website workflows should be based on npm now and FDC3 workbench comes back clean from an audit, build and fdc3-workbench app are both working. Hence, please check the output @robmoffat and let me know to merge. There are still vulnerabilities in the website and main project being reported, but this is a good first step. I'll look at the main project next. For the website... we might just have to go to docusaurus v2, which is on the todo list anyway. |
P.S. #808 will need rebasing onto main or this branch and will probably need the lock files removed as they will definitely conflict with the ones in this PR - and again after other fixes for other deps issues go in for the main project. |
I'm not sure how to test this without us first merging #808 |
You can checkout the branch and npm audit the fdc3-workbench folder +
observe that the workflows ran on it ok (not including the scans from the
other pr not yet merged). I checked that the workbench it builds is working
ok already. That can be tested with the FDC3 chrome extension or
electron-fdc3 if necessary.
…On Fri, 16 Sept 2022, 08:39 Rob Moffat, ***@***.***> wrote:
I'm not sure how to test this without us first merging #808
<#808>
If we do that, we should be able to see the results of the scan in this PR.
—
Reply to this email directly, view it on GitHub
<#816 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM7PBBSIA44KRQPGMSRATDV6QP3HANCNFSM6AAAAAAQMY3UTI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
resolves #812
Overrides vulnerable dependencies to ensure a clean
npm audit