Confirm that App channels do not re-play past contexts when a listener is added #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for lambent-kulfi-cf51a7 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
kriswest
commented
Dec 14, 2022
robmoffat
added a commit
that referenced
this pull request
Jan 16, 2023
robmoffat
added a commit
that referenced
this pull request
Jan 16, 2023
robmoffat
added a commit
that referenced
this pull request
Jan 16, 2023
|
Also added some code to be consistent with other steps. Can you review and close this PR if it's good? |
Looks good to me! Closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small addition to one of the app channel tests - we need to confirm that App Channels, listened to via the
Channelinterface do not auto-replay context messages (as System/User channels listened to through the fdc3/Desktop Agent interface do).A different PR will add this to the 2.0 test cases.
Background:
The Standards Working Group re-affirmed under issue #511 at meeting #683 that the difference in the behaviour of the
fdc3/DesktopAgentandChannelinterfaces was intentional and necessary to implement certain use cases with App Channels. It was decided that this would not change in FDC3 2.0, hence it remains the case in 2.0.