Remove malformed context test case as correct behavior is not defined #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the Standard The FDC3 Standard does not define the expected behavior on receipt of a malformed context (by fdc3.open, or indeed any other function). Hence, it is not possible to adequately define test cases for it. There currently only exists a test case for fdc3.open which this PR will remove.
kriswest
added
api
kriswest
requested review from
mattjamieson,
robmoffat,
nkolba,
rikoe,
mistryvinay,
hughtroeger,
ggeorgievx,
openfin-johans and
a team
✅ Deploy Preview for lambent-kulfi-cf51a7 canceled.
|
ggeorgievx
approved these changes
Dec 2, 2022
robmoffat
approved these changes
Dec 2, 2022
nkolba
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FDC3 Standard does not define the expected behavior on receipt of a malformed context (by
fdc3.open, or indeed any other function). Hence, it is not possible to adequately define test cases for it. There currently only exists a test case forfdc3.openwhich this PR will remove.See issue #872 for a request to refine this FDC3 so that we can test it in a future version.