Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing createPrivateChannel and findInstances fns to Methods.ts #876

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

kriswest
Copy link
Contributor

@kriswest kriswest commented Dec 6, 2022

The NPM module is missing an a function for createPrivateChannel. This PR adds the function and rolls the pre-release version number so that the NPM module will release itself

@kriswest kriswest added bug Something isn't working api FDC3 API Working Group labels Dec 6, 2022
@netlify
Copy link

netlify bot commented Dec 6, 2022

Deploy Preview for lambent-kulfi-cf51a7 canceled.

Name Link
🔨 Latest commit fca10bd
🔍 Latest deploy log https://app.netlify.com/sites/lambent-kulfi-cf51a7/deploys/63907885db1189000801618c

@kriswest kriswest changed the title Add missing createPrivateChannel fn to Methods.ts Add missing createPrivateChannel and findInstances fns to Methods.ts Dec 7, 2022
Copy link
Contributor

@mattjamieson mattjamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kriswest
Copy link
Contributor Author

kriswest commented Dec 7, 2022

Muchas gracias @mattjamieson !

@kriswest kriswest merged commit e8d0248 into master Dec 7, 2022
@kriswest kriswest deleted the adding-missing-fn-to-method.ts branch December 7, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api FDC3 API Working Group bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants