Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm vite workbench 2 #923

Merged
merged 19 commits into from
Mar 20, 2023
Merged

Rm vite workbench 2 #923

merged 19 commits into from
Mar 20, 2023

Conversation

robmoffat
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Mar 9, 2023

Deploy Preview for fdc3 ready!

Name Link
🔨 Latest commit 6311df9
🔍 Latest deploy log https://app.netlify.com/sites/fdc3/deploys/641834d1eaea30000721587d
😎 Deploy Preview https://deploy-preview-923--fdc3.netlify.app/toolbox/fdc3-workbench
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@robmoffat robmoffat requested review from kriswest and removed request for kriswest March 9, 2023 13:24
@kriswest kriswest requested a review from mattjamieson March 9, 2023 14:22
@kriswest
Copy link
Contributor

kriswest commented Mar 9, 2023

Looks like a working preview to me (i.e. CSS is present) - what did it take to fix?

I note preview link goes goes direct to workbench, although the rest of the site is there too. Did you have to mess with the build setup significantly to make it work?

netlify.toml file will now build on all changes, including to /src dir and other files that don't affect website - not a problem unless FINOS is charged per build ;-)

Added @mattjamieson for a look.

@mattjamieson
Copy link
Contributor

Looks good to me, though we should probably back out a few of the changes I made while testing before we merge

@robmoffat robmoffat marked this pull request as ready for review March 9, 2023 15:21
@robmoffat robmoffat requested a review from kriswest March 9, 2023 15:21
@robmoffat
Copy link
Member Author

@mattjamieson @kriswest can you guys give this the once-over?

Copy link
Contributor

@mattjamieson mattjamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I've added suggestions to remove the debugging/trial stuff I added while trying to get the netlify build to work. Assuming it doesn't cause issues it would be better to keep the configs as simple as possible for future maintenance!

Co-authored-by: Matt Jamieson <10372+mattjamieson@users.noreply.github.com>
@mattjamieson mattjamieson self-requested a review March 20, 2023 14:21
@kriswest kriswest merged commit f849c7c into master Mar 20, 2023
@kriswest kriswest deleted the rm-vite-workbench-2 branch March 20, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants