-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rm vite workbench 2 #923
Rm vite workbench 2 #923
Conversation
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Looks like a working preview to me (i.e. CSS is present) - what did it take to fix? I note preview link goes goes direct to workbench, although the rest of the site is there too. Did you have to mess with the build setup significantly to make it work? netlify.toml file will now build on all changes, including to /src dir and other files that don't affect website - not a problem unless FINOS is charged per build ;-) Added @mattjamieson for a look. |
Looks good to me, though we should probably back out a few of the changes I made while testing before we merge |
@mattjamieson @kriswest can you guys give this the once-over? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I've added suggestions to remove the debugging/trial stuff I added while trying to get the netlify build to work. Assuming it doesn't cause issues it would be better to keep the configs as simple as possible for future maintenance!
Co-authored-by: Matt Jamieson <10372+mattjamieson@users.noreply.github.com>
No description provided.