Deprecating IntentMetadata.displayname #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fdc3 canceled.
|
kriswest
added
api
hughtroeger
reviewed
Mar 9, 2023
mattjamieson
requested changes
Apr 5, 2023
| @@ -607,7 +607,8 @@ components: | |||
| properties: | |||
| displayName: | |||
| type: string | |||
| description: An optional display name for the intent that may be used in UI instead of the name. | |||
| description: Optional display name for the intent. Deprecated in favour of the Intent name, which is common amongst all apps that support it, where teh display name may vary. | |||
There was a problem hiding this comment.
Suggested change
| description: Optional display name for the intent. Deprecated in favour of the Intent name, which is common amongst all apps that support it, where teh display name may vary. | |
| description: Optional display name for the intent. Deprecated in favour of the intent name, which is common amongst all apps that support it, where the display name may vary. |
Co-authored-by: Matt Jamieson <10372+mattjamieson@users.noreply.github.com>
Co-authored-by: Matt Jamieson <10372+mattjamieson@users.noreply.github.com>
kriswest
commented
Apr 5, 2023
|
Changes applied - needs signing off again @mattjamieson @greyseer256 |
|
@greyseer256 this'll need your review before its merged |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #312
Marking IntentMetadata.displayName as deprecated as it can only come from app definitions in appD, which means the DA needs to pick one and all could be different. SWG agreed to go with the intent name instead as thats always the same AND is required to be recognizable