Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fdc3 2.0 workbench update #947

Conversation

kriswest
Copy link
Contributor

@kriswest kriswest commented Apr 11, 2023

resolves #787
resolves #788

An updated version of the FDC3 workbench for FDC3 2.0, which now includes:

  • the ability to switch between 1.2 and 2.0 versions of the workbench
  • the ability to target raiseIntent and raiseIntentForContext, using options gathered via findIntent and findIntentByContext
  • the ability to set up intentResults in intent listeners - including both context and channel results, channel results can have contexts broadcast on to the channel
  • a number of bug fixes, including polyfill of the node process module used in the schema validator
  • tightened up layout in header and contexts tab
  • updated schema URLs pointing to 'next'
  • updated some website dependencies to improve the npm-audit results
  • updated the redocly CDN URL for the appD page

Still in need of an update to MUI v5 (one day)

kenny-ciq and others added 30 commits November 10, 2022 16:29
add ability to send multiple contexts
adding logs to private channel functions
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 19, 2023

@kriswest
Copy link
Contributor Author

/easycla

@kriswest
Copy link
Contributor Author

kriswest commented Apr 19, 2023

@TheJuanAndOnly99 @robmoffat I believe the EasyCLA error on this PR:

image

is down to an EasyCLA bug. The two commits reported as having a missing user are linked to two users - they are merge commits for PRs into the PR branch, raised by one user and then altered and merged by another:

image

image

These are the only two commits in the PR linked to multiple users.

EasyCLA Bug report submitted: https://jira.linuxfoundation.org/plugins/servlet/desk/portal/4/SUPPORT-17792

@kriswest
Copy link
Contributor Author

/easycla

@nickmango
Copy link

/easycla

@jarias-lfx
Copy link

/easycla

Copy link
Contributor

@hughtroeger hughtroeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

Two things I noticed while testing, the 'All' context listener type didn't seem to register anything when I was broadcasting instruments, I know it used to, is that expected?

Also the right hand panel under the channels tab still says "System Channels" should that say "User Channels" now?

image

@kriswest
Copy link
Contributor Author

Handled @greyseer256's comments, conflicts and a few issues I found in app channels. Needs another maintainer review before it can be merged.

Copy link
Contributor

@mattjamieson mattjamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kriswest kriswest merged commit 428c123 into finos:master May 17, 2023
@kriswest kriswest deleted the 49664-fdc3-2.0-workbench-enhancement-git-cleanup-2 branch May 17, 2023 13:56
@kriswest kriswest mentioned this pull request May 25, 2023
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolbox Apps or code that isn't part of the standard but supports it use
Projects
None yet
7 participants