-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fdc3 2.0 workbench update #947
fdc3 2.0 workbench update #947
Conversation
…/ChartIQ/FDC3 into 49664-fdc3-2.0-workbench-enhancement
…/ChartIQ/FDC3 into 49664-fdc3-2.0-workbench-enhancement
….com/ChartIQ/FDC3 into 49664-app-metadata
49664 app metadata
add receving intent results
add ability to send multiple contexts
adding logs to private channel functions
|
…rkbench-enhancement-git-cleanup-2
/easycla |
@TheJuanAndOnly99 @robmoffat I believe the EasyCLA error on this PR: is down to an EasyCLA bug. The two commits reported as having a missing user are linked to two users - they are merge commits for PRs into the PR branch, raised by one user and then altered and merged by another: These are the only two commits in the PR linked to multiple users. EasyCLA Bug report submitted: https://jira.linuxfoundation.org/plugins/servlet/desk/portal/4/SUPPORT-17792 |
/easycla |
/easycla |
…nto 49664-fdc3-2.0-workbench-enhancement-git-cleanup-2
…rkbench-enhancement-git-cleanup-2
/easycla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good!
Two things I noticed while testing, the 'All' context listener type didn't seem to register anything when I was broadcasting instruments, I know it used to, is that expected?
Also the right hand panel under the channels tab still says "System Channels" should that say "User Channels" now?
…rkbench-enhancement-git-cleanup-2
Handled @greyseer256's comments, conflicts and a few issues I found in app channels. Needs another maintainer review before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
resolves #787
resolves #788
An updated version of the FDC3 workbench for FDC3 2.0, which now includes:
raiseIntent
andraiseIntentForContext
, using options gathered viafindIntent
andfindIntentByContext
Still in need of an update to MUI v5 (one day)