Changed website to FINOS Branding & changes to Custom CSS & New Logos #96
Conversation
Merging Upstream
…working on Use Cases section to change background colors of sections
…ion on black vs blue
… Design Changes section at the bottom
There was a problem hiding this comment.
@grizzwolf this looks great, thanks a lot.
I have two small issues with your changes:
- The header spacing on the documentation pages are now out of alignment.
- When in responsive mode, we no longer have the darker colour in responsive mode to indicate which page has been selected. In fact, the heading seems to be missing entirely.
The darker colour is controlled by secondaryColor config option (see https://github.com/FDC3/FDC3/blob/master/website/siteConfig.js#L46).
Happy to work with you on fixing these issues.
…onsive version - added ChartIQ to Users
|
Hi @rikoe - gotcha on those changes. Have just run through them locally. I've changed:
@rikoe - is it best for me to submit a new PR with these changes? I don't know how to change this PR (if you can even do that). Thanks - Griz |
|
No need to do anything extra - if you add your commits to the same branch that you did the PR from, it automatically rolls forward to incorporate them, e.g. see https://github.com/FDC3/FDC3/pull/96/files/c528e24587710959f816b993617019a2fff804f7..d2dfa45b4d44a298cae2c2d2935de2b7cc46932f. I have had a look at the changes, looks good to me now, thanks! |
|
@grizzwolf are you sure the changes you just made to the img paths worked? On your website I see this:
|
|
I see that too - let me confirm. |
|
In the FDC3 repo - your json file has "image": "/img/users/adaptive.webp", with the "/" before img. I think my set up may be different in the config file (something Mao and I were working on to get the initial test site going) - let me duplicate the siteConfig.js file from the current version to get it all on par. |
|
my base URL is different |
…"/" infront of img to keep in line with base URL
Why did you need to make the change to remove the leading slash in the first place, it worked fine before (and is working fine at the moment)? |
| url: 'https://grizzwolf.github.io/FDC3/', | ||
| //cname: 'fdc3.finos.org', | ||
| baseUrl: '/FDC3/', | ||
| url: 'https://fdc3.finos.org', |
There was a problem hiding this comment.
Ah. I see what happened now. This is a thorny problem to solve, it happened to me too. I think it is an unresolved issue on Docusaurus, how to target the same config & website at different URLs.
👍
There was a problem hiding this comment.
yes - that's better than my explanation. It was frustrating when we couldn't get it running, and figured out the base URL change (when forking in personal repos). Let me know if any issues other than that.
…ogo) work on this build (issue with base URLs in Docusaurus)
|
@rikoe - quick thing. I think there was a logo that wasn't working in a Travis CI build on https://grizzwolf.github.io/FDC3/. I temporarily reverted the siteConfig.js and users.json files to make the Travis CI build work with all the logos - then reverted back to the correct version for the PR. Should be good to go - Gab and I just didn't want someone looking at the logos and think we missed something or something was broken. Thanks! |
|
@rikoe Thanks for putting up the merge! I've been checking a couple of things - and I found out that iOS doesn't support .webp images (from Firefox). Everything looks great on desktop - but on an iPhone, all but the Scott Logic "user" images are hidden. Scott Logic was the only one that was a .png. Do you want me to re-add all of these images as .png's and then post another PR? adding @maoo to this for reference too. |
|
Plus - I have access to all the image files for the FINOS members - so I'll just do that anyway and send the PR. Looks like the standard Docusaurus Users addition is the .webp - and iOS (both Chrome and Safari) have not accepted it yet: Mozilla this week announced that it will support Google's compressed WebP image format in Firefox, leaving Apple's Safari as the one flagship browser without any compatibility. ... Because of Apple policies, third-party iOS browsers — even Google Chrome — must use the same underlying engine as Safari.Oct 5, 2018 |
|
That sounds like a great idea. Thanks for catching this.
Riko
…On Tue, 9 Jul 2019 at 15:43, Aaron Griswold ***@***.***> wrote:
Plus - I have access to all the image files for the FINOS members - so
I'll just do that anyway and send the PR. Looks like the standard
Docusaurus Users addition is the .webp - and iOS (both Chrome and Safari)
have not accepted it yet:
https://appleinsider.com/articles/18/10/05/firefox-gets-support-for-googles-webp-image-format-leaving-apple-safari-as-main-holdout
Mozilla this week announced that it will support Google's compressed WebP
image format in Firefox, leaving Apple's Safari as the one flagship browser
without any compatibility. ... Because of Apple policies, third-party iOS
browsers — even Google Chrome — must use the same underlying engine as
Safari.Oct 5, 2018
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/FDC3/FDC3/pull/96?email_source=notifications&email_token=AAZEPC6PYM4HM5IOS5II6WDP6SPZ3A5CNFSM4H4AO4LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZQPT4Q#issuecomment-509671922>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAZEPC3AINLOOJXWCZZIXQLP6SPZ3ANCNFSM4H4AO4LA>
.
|
|
Roger - working on it now. (and this helps me with other Microsites down the road...) I'll also note it in the README.md |
For a view of the changes proposed in this PR - please refer to my test site for FDC3: https://grizzwolf.github.io/FDC3/