Updating project to node 18 #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating lock files, github workflows and adding an .nvmrc file (for netlify) for node 18. Removing engines from package.json as it ends up in node module and should not. Rolling npm module version so that it releases (without engines restriction)
kriswest
added
website
project infrastructure
toolbox
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…tools to .nvmrc) and replicating in website directory
Merged
mattjamieson
approved these changes
Apr 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #964
Updating lock files, github workflows and adding an .nvmrc file (for netlify) and .node-version (other tools) for node 18 in both the root of the repository and the website directory (where netlify will read from).
Removing engines from package.json as it ends up in node module and should not.
Rolling npm module version so that it releases (without engines restriction).
Correct version is selected by netlify:
Previews all seem good: