Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

544 Desktop Agent Bridging #968

Merged
merged 126 commits into from
Jul 26, 2023
Merged

544 Desktop Agent Bridging #968

merged 126 commits into from
Jul 26, 2023

Conversation

kriswest
Copy link
Contributor

@kriswest kriswest commented Apr 25, 2023 •
edited
Loading

supersedes #861
resolves #453
resolves #544

Implements a new Part in the FDC3 Standard: Desktop Agent Bridging

kriswest and others added 30 commits November 23, 2022 10:37
@kriswest
adding bridging spec to fresh branch
17d170c
@kriswest
Clarify generation of responseGuid for collated messages, add message…
a55c8d4 
… exchange for getAppMetadata
@kriswest
Adding meta.errorDetails array to collate error messages, BridgingE…
4368c32 
…rror enumeration and notes on raiseIntentForCOntext handling via findIntentsByContext and raiseIntent
@kriswest
change in website dir to trigger preview generation
939c29b
Fixed typos
9d07e88
proposal update
65c701b
fix type definition
01a4cb8 
typo
Adding schemas for types
d0b5e5f
Merge branch 'master' into 544-Desktop-Agent_bridging-Proposal-mk2
a57f286
@kriswest
Merge remote-tracking branch 'upstream/master' into 544-Desktop-Agent…
ccf4965 
…_bridging-Proposal-mk2
@kriswest
add support for mermaid diagrams to website
e192658
@kriswest
breakout message exchange in reference pages
86e8f28
@kriswest
Merge remote-tracking branch 'upstream/quicktype-update' into 544-Des…
f7c5995 
…ktop-Agent_bridging-Proposal-mk2
@kriswest
Updated front page icons and added bridging icon
c02a9ea
@kriswest
update cpy-cli version to resolve vulnerable dep
19ab450
@kriswest
Merge remote-tracking branch 'upstream/master' into 544-Desktop-Agent…
dcd68fe 
…_bridging-Proposal-mk2
@kriswest
Adjust markdown linting rules and apply fixes to API docs where needed
2bcea49
@kriswest
more minor linting fixes
6c30424
@kriswest
Add a UUID standard reference to docs (referred to in bridging spec)
2837ffe
@kriswest
Add missing theme for mermaid diagrams to website/package.json
42c3da2
@kriswest
Integrate new error details into api spec and api-bridging reference …
654935a 
…files
@kriswest
Adding new terms and acronyms for bridging to glossary
b9e950f
@kriswest
adjusting TODOs in spec
b4e50fc
@kriswest
adding a missing error and adjusting TODOs
ae809b9
@kriswest
Adding new errors to API sources
3662f73
@kriswest
Adding bridging errors, DesktopAgentIdentifier to API specs and sources
b35f7a1
@kriswest
Comment cleanup
1b2e110
@kriswest
Update details on inter-agent communication
d7c2251
@kriswest
Experimental flags + improving some comments
6830c73
@tpina @kriswest
new schema structure (#65)
37d2f53 
* new schema structure
quicktypeUtils update
npm scripts update

* PR feedback

* cleanup

* typos

* fix type generation folder

* Fixed schema structures

* copy schemas to website

* package json update

* removed defunct file

* make sources optional

* cleanup

* Update schemas/bridging/raiseIntentResultResponse.schema.json

Co-authored-by: Kris West <kris@cosaic.io>

* cleanup

* regenerated types

* PR feedback

* Fixe meta for requests

* Apply suggestions from code review

* Regenerating bridging typescript

* Apply suggestions from code review

* adjust OptionalFeatures and IntentResult schemas

---------

Co-authored-by: Kris West <kris@cosaic.io>
kriswest and others added 2 commits July 26, 2023 10:44
@kriswest kriswest requested a review from hughtroeger July 26, 2023 09:53
@kriswest
Copy link
Contributor Author

@hughtroeger I believe all your comments are dealt with

mattjamieson
mattjamieson requested changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@mattjamieson mattjamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things, otherwise looking great.

SCOPE.md Outdated Show resolved Hide resolved
docs/agent-bridging/ref/findInstances.md Outdated Show resolved Hide resolved
docs/agent-bridging/ref/findInstances.md Outdated Show resolved Hide resolved
docs/agent-bridging/ref/findInstances.md Outdated Show resolved Hide resolved
docs/agent-bridging/ref/findInstances.md Outdated Show resolved Hide resolved
docs/agent-bridging/ref/findInstances.md Outdated Show resolved Hide resolved
@kriswest @mattjamieson
Apply suggestions from code review
0b481f0 
Co-authored-by: Matt Jamieson <10372+mattjamieson@users.noreply.github.com>
@kriswest kriswest requested a review from mattjamieson July 26, 2023 10:23
mattjamieson
mattjamieson approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@mattjamieson mattjamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Thanks to everyone for all the hard work getting to this point!

@kriswest
Add the app to each reference page mermaid diagram to clarify how mes… (
a6fb49b 
#80)

* Add the app to each reference page mermaid diagram to clarify how message exchanges work

* Changing arrow style for FDC3 API calls + adding expect type for promise resolution to mermaid diagrams

* fix box in mermaid diagram
mattjamieson
mattjamieson approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@mattjamieson mattjamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kriswest kriswest merged commit 2a535a4 into finos:master Jul 26, 2023
@kriswest kriswest deleted the 544-Desktop-Agent_bridging-Proposal-mk2 branch July 26, 2023 17:38
@bingenito bingenito mentioned this pull request Nov 6, 2023
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikoe rikoe rikoe left review comments

@nkolba nkolba nkolba left review comments

@hughtroeger hughtroeger hughtroeger approved these changes

@mattjamieson mattjamieson mattjamieson approved these changes

@Vivek-NatWest Vivek-NatWest Awaiting requested review from Vivek-NatWest

Assignees
No one assigned
Labels
Desktop Agent Bridging Desktop Agent Bridging Discussion Group enhancement New feature or request
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

Support the production of Desktop Agent Bridging
10 participants
@kriswest @openfin-johans @nkolba @robmoffat @fboisson74 @Vivek-NatWest @mattjamieson @rikoe @hughtroeger @tpina