Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

827 Adding appD error route examples #973

Merged
merged 2 commits into from
May 11, 2023
Merged

827 Adding appD error route examples #973

merged 2 commits into from
May 11, 2023

Conversation

kriswest
Copy link
Contributor

resolves #827
Also corrects a few spelling errors in the appD schema

@kriswest kriswest added bug Something isn't working app-directory labels Apr 28, 2023
@kriswest kriswest requested review from hughtroeger and a team April 28, 2023 15:45
@netlify
Copy link

netlify bot commented Apr 28, 2023 •
edited
Loading

✅ Deploy Preview for fdc3 canceled.

Name Link
🔨 Latest commit ddbdae6
🔍 Latest deploy log https://app.netlify.com/sites/fdc3/deploys/644bef3892f99e0007240497

hughtroeger
hughtroeger approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@hughtroeger hughtroeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mattjamieson
mattjamieson approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@mattjamieson mattjamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kriswest kriswest merged commit bf9bc2b into master May 11, 2023
@kriswest kriswest deleted the 827-appd-error-route-examples branch May 11, 2023 07:57
@kriswest kriswest mentioned this pull request May 25, 2023
Closed
27 tasks
@bingenito bingenito mentioned this pull request Nov 6, 2023
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughtroeger hughtroeger hughtroeger approved these changes

@mattjamieson mattjamieson mattjamieson approved these changes

Assignees
No one assigned
Labels
app-directory bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AppD v2 routes don't define error response samples
3 participants
@kriswest @mattjamieson @hughtroeger