Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

980 Correcting appd interop.appChannels to use id instead of name #981

Merged
merged 2 commits into from
May 31, 2023
Merged

980 Correcting appd interop.appChannels to use id instead of name #981

merged 2 commits into from
May 31, 2023

Conversation

kriswest
Copy link
Contributor

resolves #980

Swaps out interop.appChannels.name for interop.appChannels.id - use of name was inadvertent and confusing (as channels have an id and an optional displayMetadata.name)

@kriswest kriswest added bug Something isn't working app-directory labels May 11, 2023
@kriswest kriswest added this to the 2.1 milestone May 11, 2023
@netlify
Copy link

netlify bot commented May 11, 2023 •
edited
Loading

✅ Deploy Preview for fdc3 canceled.

Name Link
🔨 Latest commit 68c1c10
🔍 Latest deploy log https://app.netlify.com/sites/fdc3/deploys/645cda851a7dff0008d0b7b4

@kriswest kriswest requested review from a team May 11, 2023 12:07
@kriswest kriswest removed this from the 2.1 milestone May 17, 2023
mattjamieson
mattjamieson approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@mattjamieson mattjamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kriswest kriswest mentioned this pull request May 25, 2023
Closed
27 tasks
@kriswest kriswest requested a review from hughtroeger May 30, 2023 10:13
@kriswest kriswest merged commit 3c4a61a into master May 31, 2023
@bingenito bingenito mentioned this pull request Nov 6, 2023
Closed
18 tasks
@kriswest kriswest deleted the 980-appd-interop-appchannels-id branch November 13, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughtroeger hughtroeger hughtroeger approved these changes

@rikoe rikoe rikoe approved these changes

@mattjamieson mattjamieson mattjamieson approved these changes

Assignees
No one assigned
Labels
app-directory bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

appD interop.appChannels uses channel name instead of id
4 participants
@kriswest @mattjamieson @rikoe @hughtroeger