Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation tags to customConfig entries in appD schema #982

Merged
merged 4 commits into from
Jul 18, 2023

Conversation

kriswest
Copy link
Contributor

@kriswest kriswest commented May 11, 2023

resolves #900

Sets the deprecated flag on customConfig elements in the appD spec:
image

prepares for #1006 expected post FDC3 2.1.

@kriswest kriswest added this to the 2.1 milestone May 11, 2023
@kriswest kriswest requested review from a team May 11, 2023 12:54
@netlify
Copy link

netlify bot commented May 11, 2023

Deploy Preview for fdc3 canceled.

Name Link
🔨 Latest commit 8bfb259
🔍 Latest deploy log https://app.netlify.com/sites/fdc3/deploys/6499741bec1acb00086acf3f

@kriswest kriswest removed this from the 2.1 milestone May 17, 2023
@kriswest kriswest mentioned this pull request May 25, 2023
27 tasks
@kriswest kriswest removed the request for review from a team May 25, 2023 15:17
@kriswest
Copy link
Contributor Author

kriswest commented May 25, 2023

Un-assigning editor review and converting to a draft PR after meeting:

@lspiro-Tick42 @robmoffat and Alex@Citi all spoke up for a use-case for a vendor independent config that is readable by an app through the FDC3 API (the original intended purpose for this appD config field). There was a suggestion that it might be better understood if renamed to better reflect purpose and that a change to the FDC3 API should be proposed to make it accessible via standardized functions.

@kriswest suggested that this should be raised as a new issue and would be happy to collaborate on a proposal/PR. The topic should be addressed at a future FDC3 SWG meeting.

@kriswest kriswest marked this pull request as draft May 25, 2023 15:21
@kriswest kriswest changed the title add deprecation tags to customConfig entries in appD schema [DO NOT MERGE] add deprecation tags to customConfig entries in appD schema May 31, 2023
@kriswest kriswest changed the title [DO NOT MERGE] add deprecation tags to customConfig entries in appD schema Add deprecation tags to customConfig entries in appD schema Jun 26, 2023
@kriswest kriswest added api FDC3 API Working Group deprecation Deprecating or removing features post deprecation labels Jun 26, 2023
@kriswest kriswest requested a review from hughtroeger June 26, 2023 11:10
@kriswest
Copy link
Contributor Author

Revived at #1013 (to be included in FDC3 2.1) as prep for:

@kriswest
Copy link
Contributor Author

@greyseer256 this deprecation is ready for your review now.

@kriswest kriswest marked this pull request as ready for review June 26, 2023 11:19
@kriswest kriswest merged commit a699ef5 into master Jul 18, 2023
@kriswest kriswest deleted the 900-deprecate-custom-config branch July 18, 2023 09:14
@bingenito bingenito mentioned this pull request Nov 6, 2023
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api FDC3 API Working Group deprecation Deprecating or removing features post deprecation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: customConfig vs hostManifests in v2
3 participants