Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detailed secret management features #519

Merged
merged 10 commits into from
Nov 25, 2024

Conversation

smendis-scottlogic
Copy link
Contributor

This is enhancement of secret management features submitted by kamran

damienjburks
damienjburks previously approved these changes Nov 9, 2024
mlysaght2017
mlysaght2017 previously approved these changes Nov 18, 2024
@smendis-scottlogic
Copy link
Contributor Author

Hi @damienjburks, can you re-approve this please? I had to rebase.

@smendis-scottlogic smendis-scottlogic added the taxonomy Work related to the Taxonomy WG label Nov 25, 2024
@damienjburks
Copy link
Contributor

Fix the YAML lint issue @smendis-scottlogic, and I'll approve.

Copy link
Contributor

@eddie-knight eddie-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested changes for yaml lint

services/crypto/secrets/features.yaml Outdated Show resolved Hide resolved
services/crypto/secrets/features.yaml Outdated Show resolved Hide resolved
services/crypto/secrets/features.yaml Outdated Show resolved Hide resolved
services/crypto/secrets/features.yaml Outdated Show resolved Hide resolved
services/crypto/secrets/metadata.yaml Outdated Show resolved Hide resolved
Co-authored-by: Eddie Knight <knight@linux.com>
Co-authored-by: Eddie Knight <knight@linux.com>
Co-authored-by: Eddie Knight <knight@linux.com>
Co-authored-by: Eddie Knight <knight@linux.com>
Co-authored-by: Eddie Knight <knight@linux.com>
@smendis-scottlogic
Copy link
Contributor Author

@eddie-knight thanks! @damienjburks back to you

@damienjburks damienjburks merged commit a0198a3 into finos:main Nov 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
taxonomy Work related to the Taxonomy WG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants