Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JEAN BAPTISTE ZIADE CorporateActionEnrichment_FRAGMOS #3220

Conversation

regnosys-prod-user
Copy link
Collaborator

No description provided.

Enrichmenent of CorporateAction event
@regnosys-prod-user regnosys-prod-user requested a review from a team as a code owner November 6, 2024 10:37
@regnosys-prod-user regnosys-prod-user added the Rosetta This Pull Request can be viewed in Rosetta label Nov 6, 2024
Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for finos-cdm ready!

Name Link
🔨 Latest commit d01d40a
🔍 Latest deploy log https://app.netlify.com/sites/finos-cdm/deploys/678116dc15279900089ad3c7
😎 Deploy Preview https://deploy-preview-3220--finos-cdm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JBZ-Fragmos
Copy link
Contributor

JBZ-Fragmos commented Nov 7, 2024

Background :

Target :
merge any agreed components into Dev, before next major release that will incorporate such changes into Prod

CorporateAction_Enrichment_FRAGMOS_update
@regnosys-prod-user regnosys-prod-user added Rosetta This Pull Request can be viewed in Rosetta and removed Rosetta This Pull Request can be viewed in Rosetta labels Nov 9, 2024
improve description of corporate actions
@manel-martos
Copy link
Contributor

manel-martos commented Jan 15, 2025

Hi @JBZ-Fragmos ,

Adding my comments as discussed during today's DPBE and also part of the reviews we talked back in December.

We observe the contribution extends the CorporateAction model. We think these additions improve flexibility but we have identified areas requiring further clarification and action to maintain compatibility and compliance.

The removal of the underlier attribute from the CorporateAction type does not affect event qualification logic or the downstream DRR processes. This adjustment has been discussed and accepted at the relevant Working Groups.

On the removal of the PositionEventIntentEnum -> Transfer, the DRR model as a consumer needs a clear justification or an alternative solution (e.g. Substitution). This value plays a role in reporting early termination events at the position level. It is essential to clarify how such scenarios should now be addressed and ensure that the model remains compliant with these regulatory jurisdictions.

To finalize this contribution, please resolve any existing conflicts and share the release notes.

Thanks.

@JBZ-Fragmos
Copy link
Contributor

JBZ-Fragmos commented Jan 15, 2025 via email

@JBZ-Fragmos
Copy link
Contributor

JBZ-Fragmos commented Jan 15, 2025 via email

@manel-martos
Copy link
Contributor

I have just renamed it to "novation"

@JBZ-Fragmos - we'll ask to a DRR positions SMEs to clarify this change specifically since it'll require a consumer upgrade and come back.

@JBZ-Fragmos
Copy link
Contributor

JBZ-Fragmos commented Jan 16, 2025 via email

@manel-martos
Copy link
Contributor

manel-martos commented Jan 20, 2025

@JBZ-Fragmos, the DRR consumer member has also accepted the term "Novation" instead of "Transfer" so it shouldn't prevent the contribution once ready under CDM latest version. Thanks!

@JBZ-Fragmos
Copy link
Contributor

@manel-martos thanks to you, for the review and the feedback

@JBZ-Fragmos JBZ-Fragmos added CRWG Criticality: Medium/Low and removed Rosetta This Pull Request can be viewed in Rosetta Criticality: High labels Jan 22, 2025
@JBZ-Fragmos JBZ-Fragmos closed this Feb 3, 2025
@JBZ-Fragmos
Copy link
Contributor

replaced by #3366

that is mostly same content, refactored under Prod version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants